Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pritam/myst premium markers #581

Merged
merged 2 commits into from
May 24, 2023
Merged

Conversation

pritamghanghas
Copy link
Contributor

Issue

  • Link:
  • Summary:

How

Screenshots

References

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

@pritamghanghas pritamghanghas requested review from a team as code owners May 24, 2023 08:59
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pritamghanghas pritamghanghas merged commit f67a928 into master May 24, 2023
1 check passed
@pritamghanghas pritamghanghas deleted the pritam/myst_premium_markers branch May 24, 2023 09:39
@shawaj
Copy link
Member

shawaj commented May 24, 2023

Not sure if we can use it here but just for future reference we do have the following:

def commercial_fleet_only(f):
@wraps(f)
def wrapper(*args, **kwargs):
fleet_name = os.environ.get('BALENA_APP_NAME')
fleet_id = int(os.environ.get('BALENA_APP_ID'))
if not fleet_name.endswith('-c') or fleet_id not in COMMERCIAL_FLEETS:
return redirect('/upgrade')
return f(*args, **kwargs)
return wrapper

shawaj added a commit that referenced this pull request Jun 7, 2023
- add premium indicator to firmware version

Closes: #380 
Relates-to: #581
shawaj added a commit that referenced this pull request Jun 7, 2023
- add premium indicator to firmware version
- if on a commercial fleet, this changes the "claim on dashboard" link to "view device on dashboard" as it should already be connected to the dashboard in that case

Closes: #380
Relates-to: #581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants