Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add premium indicator to firmware version and change claim link #597

Merged
merged 1 commit into from
Jun 7, 2023
Merged

feat: add premium indicator to firmware version and change claim link #597

merged 1 commit into from
Jun 7, 2023

Conversation

shawaj
Copy link
Member

@shawaj shawaj commented Jun 7, 2023 •
edited
Loading

  • add premium indicator to firmware version
  • if on a commercial fleet, this changes the "claim on dashboard" link to "view device on dashboard" as it should already be connected to the dashboard in that case

Closes: #380
Relates-to: #581

Issue

  • Link:
  • Summary:

How

Screenshots

Screenshot 2023-06-07 at 17 43 09

References

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

@shawaj shawaj requested review from a team as code owners June 7, 2023 16:46
@shawaj
feat: add premium indicator to firmware version and change claim link
676d3e8 
- add premium indicator to firmware version
- if on a commercial fleet, this changes the "claim on dashboard" link to "view device on dashboard" as it should already be connected to the dashboard in that case

Closes: #380
Relates-to: #581
@shawaj shawaj changed the title feat: add premium indicator to firmware version feat: add premium indicator to firmware version and change claim link Jun 7, 2023
@shawaj shawaj changed the base branch from master to fixes-initfile June 7, 2023 17:06
@shawaj shawaj changed the base branch from fixes-initfile to master June 7, 2023 17:07
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@shawaj shawaj merged commit 58802c8 into master Jun 7, 2023
@shawaj shawaj deleted the shawaj/premium branch June 7, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinWassermann94 KevinWassermann94 KevinWassermann94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display fleet location on diagnostics page
2 participants
@shawaj @KevinWassermann94