Update formats.py #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed the comments to match documentation as detailed in https://code.djangoproject.com/ticket/35095#comment:6
e11bits
reviewed
Jan 12, 2024
django/conf/locale/de_CH/formats.py
Outdated
| @@ -27,7 +27,7 @@ | |||
|
|
|||
| # these are the separators for non-monetary numbers. For monetary numbers, | |||
| # the DECIMAL_SEPARATOR is a . (decimal point) and the THOUSAND_SEPARATOR is a | |||
| # ' (single quote). | |||
| # , (comma). | |||
There was a problem hiding this comment.
I don't think it is a comma but also a nbsp as for plain numbers. (see my comment in the ticket). So I would think it would be correct to remove " and the THOUSAND_SEPARATOR is a x (whatever)." from the comment.
There was a problem hiding this comment.
I have added a new commit taking into account the latest changes in the thread
changes added as based on the following thread https://code.djangoproject.com/ticket/35095#comment:6, from comment 20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the comments to match documentation as detailed in https://code.djangoproject.com/ticket/35095#comment:6