Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Automated Code Review #323

Open
Nekroze opened this issue Feb 22, 2019 · 2 comments
Open

Improve Automated Code Review #323

Nekroze opened this issue Feb 22, 2019 · 2 comments
Assignees
Labels
Test Add, remove, or alter tests Tweak Change to existing components

Comments

@Nekroze
Copy link
Owner

Nekroze commented Feb 22, 2019

Change Request

Please describe the current behaviour

At present dab uses DangerJS in CI to do some basic checks on a PR to give some automated feedback.

What is suboptimal about the current behaviour

The current behaviour is insufficient because it only has a few simple checks and some of them do not appear to be working.

Describe the way you think it should behave

Codify existing rules for changes such as a new app being added (just takes a new docker-compose file) must be accompanied by a change to the apps completion file to list it there, etc.

@Nekroze Nekroze added the Tweak Change to existing components label Feb 22, 2019
@Nekroze Nekroze self-assigned this Feb 22, 2019
@Nekroze
Copy link
Owner Author

Nekroze commented Feb 22, 2019

Assigned myself as most of these rules are just in my head for now.

@Nekroze
Copy link
Owner Author

Nekroze commented Feb 25, 2019

needs to ensure PR's are not empty nor just the default template unaltered as well

@Nekroze Nekroze added the Test Add, remove, or alter tests label Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Add, remove, or alter tests Tweak Change to existing components
Projects
None yet
Development

No branches or pull requests

1 participant