Updated the Neos version msdfgen to the latest version, including the JP fix. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow build on GCC 8.3.1
… link to Atlas Gen, new example shader
* Use freetype target if it already exists in cmake build * Add cmake option controlling install targets
* Remove duplicate file filter for msdfgen-ext_SOURCES * Fix build interface include directories The root is exposed in ordered to have #include <msdfgen.h> in client code, and not #include <msdfgen/msdfgen.h>
CMake build improvements & simplification
# Conflicts: # .gitignore # CMakeLists.txt # Msdfgen.sln # Msdfgen.vcxproj # Msdfgen.vcxproj.filters # azure-pipelines.yml # core/edge-selectors.cpp # dll_api.cpp # dll_exports.h # ext/import-font.cpp # ext/import-font.h # ext/import-svg.cpp
…chain, and should be compatible up to 2019.
…or inversion as the distance sign correction fixes this already.
…able as per the library author.
Earthmark
changed the title
Neos jp character fix
SnooperXP
approved these changes
Nov 18, 2021
|
closed due to staleness, I don't think this'll get merged due to a stale platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scripts were changed to recognize Cmake as the authority, and the build scripts were updated to respect that.
Customizations to the c++ files were largely reverted, and the interface file was updated to support the new backing api.
Testing should be done before full release, as there currently are no tests verifying the safety of these changes besides manual tests.
It is much easier to view this in terms of the neos changes getting applied to the base msdfgen library, see Earthmark#6 for the changes from that perspective.
There were changes to the build scripts, I do not have access to how the output artifacts are used internally and I can not verify the changes are safe for the pipeline.
This should resolve Neos-Metaverse/NeosPublic#621