Rename project from Dynamallow to DynamORM #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akshaynanavati -- I think this is ready to roll. Can you provide a second set of eyes for me please. |
| from marshmallow import fields | ||
|
|
||
| class Book(MarshModel): | ||
| # Our objects are defined as DynaModel classes | ||
| class Book(DyanModel): |
There was a problem hiding this comment.
This should be DynaModel
|
Hi, Does that mean this: https://pypi.org/project/dynamallow/ Is a deprecated package (name)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #1 is complete and we support both Marshmallow & Schematics, we are going to rename the project from Dynamallow to DynamORM to better decouple the name from Marshmallow.
Todo: