Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SMB2 panels in Harvest #1696

Closed
rahulguptajss opened this issue Feb 8, 2023 · 5 comments · Fixed by #1754 or #1839
Closed

Implement SMB2 panels in Harvest #1696

rahulguptajss opened this issue Feb 8, 2023 · 5 comments · Fixed by #1754 or #1839
Labels
23.05 feature New feature or request status/done

Comments

@rahulguptajss
Copy link
Contributor

Thanks @Watson9121 for raising this via discord.

Investigate and implement SMB2 view in Harvest.
@rahulguptajss rahulguptajss added the feature New feature or request label Feb 8, 2023
@rahulguptajss rahulguptajss self-assigned this Feb 20, 2023
rahulguptajss added a commit that referenced this issue Feb 21, 2023
@rahulguptajss
feat: smb2 dashboard
9b46e66 
Fixes #1696
rahulguptajss added a commit that referenced this issue Feb 21, 2023
@rahulguptajss
feat: smb2 dashboard
72f72a8 
Fixes #1696
@rahulguptajss rahulguptajss mentioned this issue Feb 21, 2023
Merged
rahulguptajss added a commit that referenced this issue Feb 21, 2023
@rahulguptajss
feat: fix ci
68d9519 
Fixes #1696
@cgrinds cgrinds added the 23.05 label Feb 21, 2023
rahulguptajss added a commit that referenced this issue Mar 6, 2023
@rahulguptajss
feat: smb2 dashboard (#1754)
8f87e86 
* feat: smb2 dashboard

Fixes #1696

* feat: fix ci

Fixes #1696

* feat: add type to smb2 output

* feat: address review comments

* feat: address review comments

* feat: address review comments

* feat: address review comments

* feat: address review comments

* feat: address review comments

* feat: address review comments

* feat: address review comments

* feat: address review comments
@mamoep
Copy link

mamoep commented Mar 21, 2023

"Session Setup Latency Heatmap" panel is duplicate on the dashboard

@rahulguptajss rahulguptajss linked a pull request Mar 21, 2023 that will close this issue
fix: Session Setup Latency Heatmap panel is duplicate on the dashboard #1839
Merged
@rahulguptajss
Copy link
Contributor Author

Thanks @mamoep . It will be fixed via #1839

@mamoep
Copy link

mamoep commented Mar 30, 2023

I would like to propose a change of the color scheme for the heatmaps. That opaque light green is hard to read with Grafana Light Theme. (I can't upload screenshots due to company policy) Scheme "RdYIGn" looks good for me.

@rahulguptajss
Copy link
Contributor Author

Thanks @mamoep. It will be fixed via #1880

@rahulguptajss
Copy link
Contributor Author

verified in 23.05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
23.05 feature New feature or request status/done
Projects
None yet
Milestone
No milestone
3 participants
@cgrinds @rahulguptajss @mamoep