Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: smb2 dashboard #1754

Merged
merged 13 commits into from
Mar 6, 2023
Merged

feat: smb2 dashboard #1754

merged 13 commits into from
Mar 6, 2023

Conversation

rahulguptajss
Copy link
Contributor

Fixes #1696

image

image

image

@cgrinds
Copy link
Collaborator

cgrinds commented Feb 21, 2023

These changes look good, few general comments:

  • Not immediately clear these should be enabled by default. Let's discuss in our meeting
  • The panels probably need an SVM or cluster prefix for when multiples are selected in top vars
  • We need to ask for these to be added to rest perf too

@rahulguptajss
Copy link
Contributor Author

These changes look good, few general comments:

  • Not immediately clear these should be enabled by default. Let's discuss in our meeting
  • The panels probably need an SVM or cluster prefix for when multiples are selected in top vars
  • We need to ask for these to be added to rest perf too

We don't need top vars or SVM/cluster prefix in this dashboard. All the metrics used in dashboard are aggregation like sum,avg.

grafana/dashboards/cmode/smb2.json Outdated Show resolved Hide resolved
grafana/dashboards/cmode/smb2.json Outdated Show resolved Hide resolved
grafana/dashboards/cmode/smb2.json Outdated Show resolved Hide resolved
Hardikl
Hardikl previously approved these changes Feb 22, 2023
@rahulguptajss rahulguptajss marked this pull request as draft February 24, 2023 15:59
@rahulguptajss rahulguptajss marked this pull request as ready for review February 24, 2023 16:26
grafana/dashboards/cmode/smb2.json Outdated Show resolved Hide resolved
grafana/dashboards/cmode/smb2.json Outdated Show resolved Hide resolved
Hardikl
Hardikl previously approved these changes Feb 28, 2023
cgrinds
cgrinds previously approved these changes Mar 2, 2023
@rahulguptajss rahulguptajss merged commit 8f87e86 into main Mar 6, 2023
@rahulguptajss rahulguptajss deleted the rg2-smb2 branch March 6, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement SMB2 panels in Harvest
3 participants