Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing error handling in the code of the storage drivers #816

Closed
tksm opened this issue Mar 30, 2023 · 1 comment
Closed

Missing error handling in the code of the storage drivers #816

tksm opened this issue Mar 30, 2023 · 1 comment

Comments

@tksm
Copy link

tksm commented Mar 30, 2023

Describe the bug

We found the following error handlings missing in the code of the storage drivers. Though we've never encountered problems from these in production, I would like to report this just in case.

  1. err from clientAPI.ExportRuleList() in reconcileExportPolicyRules().

rules, err := clientAPI.ExportRuleList(ctx, policyName)
for _, rule := range desiredPolicyRules {

2. err from c.ExportPolicyList() in ExportPolicyGetByName().

result, err := c.ExportPolicyList(ctx, exportPolicyName)
if result.Payload.NumRecords == 1 && result.Payload.Records != nil {

Environment

  • Trident version: 23.01.1
@tksm tksm added the bug label Mar 30, 2023
@gnarl gnarl added the tracked label Apr 3, 2023
@gnarl
Copy link
Contributor

gnarl commented May 18, 2023

This issue is fixed with commit 7221bdc and will be included in the next major Trident release.

@gnarl gnarl closed this as completed May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants