-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) Support 3D rendering in headless mode #833
Conversation
This reverts commit e2e8f97. I mistakenly thought these previews could be generated automatically generated. If NetLogo/NetLogo#833 ever gets completed and merged, I'll revert the revert...
...regardless of what the preview commands say. If NetLogo/NetLogo#833 gets completed and merged, this could be reverted.
Running `all-previews` in headless 3d is not very useful (at least until, if ever, #833 is completed), but this will at least avoid messing up the models themselves.
Running `all-previews` in headless 3d is not very useful (at least until, if ever, #833 is completed), but this will at least avoid messing up the models themselves.
Old comment made by @frankduncan on gitter (pasting here so I don't forget):
|
- Some of them had custom or default commands that didn't compile - We want models to tell the truth about their preview commands that being said, if/when NetLogo/NetLogo#833 is completed, some the custom commands eliminated here could very well be reused.
- Some of them had custom or default commands that didn't compile - We want models to tell the truth about their preview commands that being said, if/when NetLogo/NetLogo#833 is completed, some the custom commands eliminated here could very well be reused.
@nicolaspayette , I should have asked you this question a while back, but do you consider this PR to still be useful and important? It will need some modifications to make it into hexy, but seems doable at this point. |
Useful, yes. Important? Not especially. I'd like to resume working on it Nicolas
|
Closing as this is pointing to 5.x |
I started tinkering on this a couple of weeks ago after a chat with Seth made me realize that the 3D view currently cannot be exported from headless mode.
I would very much like to have that working in order to automatically generate the preview images for 3D models. It would also improve regression testing for NetLogo 3D.
My efforts so far have failed, and then I had to move on to other stuff. I'll give it a another try when/if time permits, but I wanted to at least have the work in progress out there in the meanwhile.