Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3] workflow: Compile on Debian with cracklib, ldap, quota #653

Merged
merged 3 commits into from Jan 8, 2024

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Jan 7, 2024

Adding a bunch of deb packages to enable configuring and compiling cracklib and ldap/acl on Ubuntu/Debian.

The quota autoconf macro doesn't seem to work anymore in Debian bookworm (or Ubuntu 22.04) so using Debian bullseye

@rdmark rdmark changed the title [2.3 workflow: Compile on Ubuntu with cracklib, ldap, quota [2.3] workflow: Compile on Ubuntu with cracklib, ldap, quota Jan 7, 2024
@rdmark rdmark force-pushed the rdmark-workflow-v2-compile-more branch from 428b25f to 1f87446 Compare January 7, 2024 00:50
@rdmark rdmark changed the title [2.3] workflow: Compile on Ubuntu with cracklib, ldap, quota [2.3] workflow: Compile on Debian with cracklib, ldap, quota Jan 7, 2024
@rdmark rdmark requested a review from dgsga January 7, 2024 01:02
Added --with-libtirpc configure flag and updated Debian container
@dgsga
Copy link
Contributor

dgsga commented Jan 7, 2024

@rdmark, just added the missing --with-libtirpc flag and quota support compiles fine on Debian Bookworm :)
Should we add a Debian workflow to Netatalk3 or is that OTT?

Attempt to compile with quota on Ubuntu
Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rdmark
Copy link
Member Author

rdmark commented Jan 8, 2024

@dgsga Right, thanks for the reminder. That option had temporary slipped my mind, despite it being me who added it a few months ago… in fact, —with-libtirpc got quota compiling on Ubuntu too!

Adding a Debian job to the v3 branch seems like a decent idea. I think it tends to be slightly more conservative with library version bumps compared to Ubuntu. Maybe even reconsidering using the oldstable image to capture an older tech stack that a lot of users are surely still using.

@rdmark rdmark merged commit 33146b3 into branch-netatalk-2-3 Jan 8, 2024
8 checks passed
@rdmark rdmark deleted the rdmark-workflow-v2-compile-more branch January 8, 2024 09:58
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Feb 5, 2024
New features

The following compile time option has been added:

    --with-docbook - Used to generate man and html pages from XML
    sources, the latter which are now included in the tarball.

Breaking changes

The following obsoleted features have been removed:

    Kerberos IV UAM - Version IV backwards compatibility headers were
    removed from Kerberos V 1.11 in 2012

    AppleDouble adouble:osx - The AD format that Mac OS X 10.3 used,
    but was removed in subsequent versions

    AppleDouble adouble:sfm - Microsoft's Services For Macintosh
    compatibility mode that required a long-gone hacked version of
    Samba

atalkd

The RTMP broadcast quirks mode that was introduced in v2.3.0 has been
replaced with an automatic activation when atalkd is configured with a
single interface and the -router flag.

Therefore, the now-unneeded -q command line option has been removed.
What's Changed

    [2.3] Fix Zeroconf support on *BSD platforms by @rdmark in
    Netatalk/netatalk#647
    [2.3] Add NetBSD, Solaris, Fedora build workflows by @rdmark in
    Netatalk/netatalk#642
    [2.3] Use correct BSD make syntax in initscripts Makefile by
    @rdmark in Netatalk/netatalk#644
    [2.3] Remove long-outdated README and VERSION files, superseded by
    man pages by @rdmark in
    Netatalk/netatalk#641
    [2.3] Two small memory handling patches ported from
    netatalk-classic by @rdmark in
    Netatalk/netatalk#645
    [2.3] macusers: Fallback output when full name not available by
    @rdmark in Netatalk/netatalk#652
    [2.3] papd: Update cups_print_job() to use CUPS destination API by
    @NJRoadfan in Netatalk/netatalk#651
    [2.3] papd: Update cups_autoadd_printers() to use current API
    call. by @NJRoadfan in
    Netatalk/netatalk#655
    [2.3] workflow: Compile on Debian with cracklib, ldap, quota by
    @rdmark in Netatalk/netatalk#653
    [2.3] Use GitHub actions v4 for workflow jobs by @rdmark in
    Netatalk/netatalk#662
    [2.3] manual: Link to custom download and wiki mirrors in navbar
    by @rdmark in Netatalk/netatalk#671
    [2.3] papd - More cleanup and moderization of print_cups.c by
    @NJRoadfan in Netatalk/netatalk#672
    [2.3] papd - Use cups_get_language() function by @NJRoadfan in
    Netatalk/netatalk#674
    [2.3] papd: Use cupsGetOptions() to get printer URI by @NJRoadfan
    in Netatalk/netatalk#678
    [2.3] atalkd: Fix for RTMP broadcast bug. by @NJRoadfan in
    Netatalk/netatalk#680
    [2.3] Workflow: Bump SonarScanner to v2 by @rdmark in
    Netatalk/netatalk#685
    [2.3] libatalk: Appease Fedora gcc incompatible pointer error by
    @rdmark in Netatalk/netatalk#683
    [2.3] afpd: Remove support for AppleDouble osx and sfm by @rdmark
    in Netatalk/netatalk#673
    [2.3] Remove obsoleted Kerberos v4 UAM by @rdmark in
    Netatalk/netatalk#686
    [2.3] Generate man pages through build system by @rdmark in
    Netatalk/netatalk#690
    [2.3] Cleanup of obsolete gitignore filters by @rdmark in
    Netatalk/netatalk#693
    [2.3] manual: Update URLs to internal resources by @rdmark in
    Netatalk/netatalk#695
    [2.3] papd: Refactor and cleanup cups_get_printer_ppd() by
    @NJRoadfan in Netatalk/netatalk#700
    [2.3] papd: update cups_get_printer_status() by @NJRoadfan in
    Netatalk/netatalk#696
    [2.3] manual: Remove obsoleted html-upload target, and update css
    URL by @rdmark in Netatalk/netatalk#701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants