[2.3] papd: Use cupsGetOptions() to get printer URI #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use cupsGetOptions() to get the printer URI from CUPS instead of hard coding it.
|
Once again, this needs to be tested against an AirPrint or "driverless" printer queue before merging. Remember that cups-browsed must be disabled before loading papd in order to test this. To test printer status retrieval, click on a desktop printer in MacOS 8 or higher, goto the "Printing" menu and click "Get Printer Configuration". You should see the status on that screen. |
This should be the job name.
|
Tested it against the "IPP Everywhere Printer" service |
|
@NJRoadfan are you happy with your testing now, or is more testing of driverless printer queues needed? I’m working offsite right now and don’t have access to my AppleTalk test bed. But I can perform supplementary testing this coming weekend. |
|
Should be good to go with this PR. Testing shows no regressions. |
rdmark
approved these changes
Jan 18, 2024
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 5, 2024
New features
The following compile time option has been added:
--with-docbook - Used to generate man and html pages from XML
sources, the latter which are now included in the tarball.
Breaking changes
The following obsoleted features have been removed:
Kerberos IV UAM - Version IV backwards compatibility headers were
removed from Kerberos V 1.11 in 2012
AppleDouble adouble:osx - The AD format that Mac OS X 10.3 used,
but was removed in subsequent versions
AppleDouble adouble:sfm - Microsoft's Services For Macintosh
compatibility mode that required a long-gone hacked version of
Samba
atalkd
The RTMP broadcast quirks mode that was introduced in v2.3.0 has been
replaced with an automatic activation when atalkd is configured with a
single interface and the -router flag.
Therefore, the now-unneeded -q command line option has been removed.
What's Changed
[2.3] Fix Zeroconf support on *BSD platforms by @rdmark in
Netatalk/netatalk#647
[2.3] Add NetBSD, Solaris, Fedora build workflows by @rdmark in
Netatalk/netatalk#642
[2.3] Use correct BSD make syntax in initscripts Makefile by
@rdmark in Netatalk/netatalk#644
[2.3] Remove long-outdated README and VERSION files, superseded by
man pages by @rdmark in
Netatalk/netatalk#641
[2.3] Two small memory handling patches ported from
netatalk-classic by @rdmark in
Netatalk/netatalk#645
[2.3] macusers: Fallback output when full name not available by
@rdmark in Netatalk/netatalk#652
[2.3] papd: Update cups_print_job() to use CUPS destination API by
@NJRoadfan in Netatalk/netatalk#651
[2.3] papd: Update cups_autoadd_printers() to use current API
call. by @NJRoadfan in
Netatalk/netatalk#655
[2.3] workflow: Compile on Debian with cracklib, ldap, quota by
@rdmark in Netatalk/netatalk#653
[2.3] Use GitHub actions v4 for workflow jobs by @rdmark in
Netatalk/netatalk#662
[2.3] manual: Link to custom download and wiki mirrors in navbar
by @rdmark in Netatalk/netatalk#671
[2.3] papd - More cleanup and moderization of print_cups.c by
@NJRoadfan in Netatalk/netatalk#672
[2.3] papd - Use cups_get_language() function by @NJRoadfan in
Netatalk/netatalk#674
[2.3] papd: Use cupsGetOptions() to get printer URI by @NJRoadfan
in Netatalk/netatalk#678
[2.3] atalkd: Fix for RTMP broadcast bug. by @NJRoadfan in
Netatalk/netatalk#680
[2.3] Workflow: Bump SonarScanner to v2 by @rdmark in
Netatalk/netatalk#685
[2.3] libatalk: Appease Fedora gcc incompatible pointer error by
@rdmark in Netatalk/netatalk#683
[2.3] afpd: Remove support for AppleDouble osx and sfm by @rdmark
in Netatalk/netatalk#673
[2.3] Remove obsoleted Kerberos v4 UAM by @rdmark in
Netatalk/netatalk#686
[2.3] Generate man pages through build system by @rdmark in
Netatalk/netatalk#690
[2.3] Cleanup of obsolete gitignore filters by @rdmark in
Netatalk/netatalk#693
[2.3] manual: Update URLs to internal resources by @rdmark in
Netatalk/netatalk#695
[2.3] papd: Refactor and cleanup cups_get_printer_ppd() by
@NJRoadfan in Netatalk/netatalk#700
[2.3] papd: update cups_get_printer_status() by @NJRoadfan in
Netatalk/netatalk#696
[2.3] manual: Remove obsoleted html-upload target, and update css
URL by @rdmark in Netatalk/netatalk#701
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use cupsGetOptions() to get the printer URI from CUPS instead of hard coding it.