Cards Block Variant: 3-card row with button #115 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cogniSyb
requested review from
SantiagoHomps-NC,
TomaszDziezykNetcentric and
markovukiceviccn
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
Lakshmishri
approved these changes
Nov 15, 2023
markovukiceviccn
approved these changes
Nov 15, 2023
TomaszDziezykNetcentric
approved these changes
Nov 15, 2023
SantiagoHomps-NC
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #115
Test URLs:
I’ve added three variants:
no-backgroundfor removing background of cards and its paddingimage-aspect-ratio-7-5to change from 16/9 aspect ratio for images to 7/5large-headingfor having a h4-style headingThe latter I’m not happy with. I’d rather utilise the CSS class h4 here, but I’m running into specificity issues.
Then, I’ve added a possibility to add buttons in cards. As per documentation I’m utilising strong/emphasis elements for the primary/secondary button. The normal state will be the standalone link.