Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: MT Powertrain V2 Slider Block #147

Closed
DanielaPedrochevd opened this issue Oct 24, 2023 · 9 comments
Closed

FR: MT Powertrain V2 Slider Block #147

DanielaPedrochevd opened this issue Oct 24, 2023 · 9 comments
Assignees
Milestone

Comments

@DanielaPedrochevd
Copy link
Collaborator

DanielaPedrochevd commented Oct 24, 2023

Agile requirement
As a content editor, I want to be able to add a block that contains an image, a title, and a button with a white or grey background to achieve the design.

Description
Develop a block with two variants.

  • 1 Variant that contains an image, a title (GT America Font Family), and a button.
  • The other variant should contain 2 images overlapped displayed with a slider through the middle, descriptive text added by the content editor, model name added by the content editor related to the images, and a title.

The design follows these figma files:

  1. https://www.figma.com/file/oNwe2jHIICPMIe551EY62l/Mack-Reskin---Full-Project?type=design&node-id=9765-36723&mode=dev
  2. (https://www.figma.com/file/oNwe2jHIICPMIe551EY62l/Mack-Reskin---Full-Project?type=design&node-id=9765-34287&mode=design) -> First Variant

The different background colors will be handled by the sections.

Acceptance criteria

  • As a content editor, I can add the new block to any page. I can add:
    • Title
    • Description text (optional)
    • Image
    • Second image (optional)
    • Model name text associated to the images (optional)
    • Link of a button (optional)
  • On mobile, the image will be as wide as the viewport. On desktop, it will be as wide as the content wrapper (1040px)
  • On desktop, the description text would be aligned at the same height as the heading, on the right. The alignment and sizing needs to be the same as done in Tabbed Carousel variant for wheelbase #190
  • For the comparison variant, the model names would take maximum 50% of the width and would be aligned to either corner of the wrapper. If the content is too long, it will wrap.
  • For the comparison variant, as a user, I can compare both images using the above-mentioned slider dragging it left or right.

Solution Direction
https://cloudfour.com/thinks/building-an-accessible-image-comparison-web-component/

@DanielaPedrochevd
Copy link
Collaborator Author

DanielaPedrochevd commented Dec 18, 2023

@WendyKruger @HaycockJill The figma file https://www.figma.com/file/oNwe2jHIICPMIe551EY62l/Mack-Reskin---Full-Project?type=design&node-id=2220-82436&mode=dev contains extra text that is not displayed in the block's desktop version. We consider this a design discrepancy and will go for the desktop design, the mobile viewport design should be the same (no extra description text).

Image

@DanielaPedrochevd DanielaPedrochevd added the Design Question RE/Dev team has open questions regarding the designs. label Dec 18, 2023
@DanielaPedrochevd
Copy link
Collaborator Author

@WendyKruger @HaycockJill As it is very complex to achieve the "comparison slider functionality" within a section of the Mack Trucks Features block #191 Would you agree we add said slider to this block instead to achieve the comparison look?

@WendyKruger
Copy link
Collaborator

@WendyKruger @HaycockJill As it is very complex to achieve the "comparison slider functionality" within a section of the Mack Trucks Features block #191 Would you agree we add said slider to this block instead to achieve the comparison look?

I'm open to seeing what that would look like.

@WendyKruger
Copy link
Collaborator

@WendyKruger @HaycockJill The figma file https://www.figma.com/file/oNwe2jHIICPMIe551EY62l/Mack-Reskin---Full-Project?type=design&node-id=2220-82436&mode=dev contains extra text that is not displayed in the block's desktop version. We consider this a design discrepancy and will go for the desktop design, the mobile viewport design should be the same (no extra description text).

Image

Yes, definitely a design error. Not sure why that text is in there to be honest. But... would we be able to have the option for text in both the desktop and mobile? Ok to make this an enhancement if needed.

@WendyKruger WendyKruger removed the Design Question RE/Dev team has open questions regarding the designs. label Dec 19, 2023
@Lakshmishri Lakshmishri self-assigned this Dec 20, 2023
@Lakshmishri Lakshmishri removed their assignment Dec 21, 2023
@markovukiceviccn
Copy link
Collaborator

@DanielaPedrochevd
I assume we should use responsive images here like in Hero block?

@DanielaPedrochevd
Copy link
Collaborator Author

DanielaPedrochevd commented Dec 27, 2023

Yes, please but keep in mind AC "For the comparison variant, the model names would take maximum 50% of the width and would be aligned to either corner of the wrapper. If the content is too long, it will wrap." and "On mobile, the image will be as wide as the viewport. On desktop, it will be as wide as the content wrapper (1040px)"

@markovukiceviccn
Copy link
Collaborator

@DanielaPedrochevd
May you show me the image resources for responsive images?

@DanielaPedrochevd
Copy link
Collaborator Author

DanielaPedrochevd commented Dec 27, 2023

@WendyKruger Can you support Marko on the above comment? In the meantime, he will use a dummy image to continue development.

@SantiagoHomps-NC SantiagoHomps-NC self-assigned this Jan 8, 2024
@DanielaPedrochevd DanielaPedrochevd changed the title FR: MT Powertrain Heading Image and Button Block FR: MT Powertrain Slider Block Jan 10, 2024
@DanielaPedrochevd DanielaPedrochevd changed the title FR: MT Powertrain Slider Block FR: MT Powertrain V2 Slider Block Jan 10, 2024
@girishdigrajkar
Copy link
Collaborator

Validated and able to get the correct result and hence, marking the issue to done status

Summary:

  1. Block sizing was observed incorrect however, then got clarification to use revised one from Syb; Sizing is correct
    https://www.figma.com/file/oNwe2jHIICPMIe551EY62l/Mack-Reskin---Full-Project?type=design&node-id=9765-36808&mode=design&t=L5N2r8ysKPH60h3Q-4
  2. Mobile / Tablet viewport looks correct except Ipad 8 +chrome shows distorted slider: [SB] This is unsupported iOS 14 hence, this issue is not considered.

cogniSyb pushed a commit that referenced this issue Jan 22, 2024
* add block
* add new section background color
manuel-vara added a commit that referenced this issue Jan 31, 2024
* Update fstab.yaml for redesign

* change url and sharepoint to upstream urls

* Inpage navigation is in reversed order on Firefox #173 (#178)

* fix Firefox issue with sorting
* fix naming issues
* refactor focus state, button styles
* fix overlap issue

* Hero V2 Block displays different images for mobile and desktop. #106 (#179)

* refactor naming structure
* refactor adaptive images mechanism

* Icon cards block (#181)

* hlxsites#509 Fix displaying header on dealer page

* fix done

* one trust position ix

* Embed block match NZ one

* Update feed.xml

* Fix createElement()  v1-Cards

* Update feed.xml

* Update release.yml

* columns block adapted

* icon cards working

* css clean

* adjustements

* last changes

* specific class

* btn state styling

* comments corrected

* secondary btn margin corrected

* secondary btn class added

* cleanup

---------

Co-authored-by: Tomasz Dziezyk <tomasz.dziezyk@netcentric.biz>
Co-authored-by: TomaszDziezykNetcentric <125962117+TomaszDziezykNetcentric@users.noreply.github.com>
Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: Syb <133873665+cogniSyb@users.noreply.github.com>

* The pop-up of the video displayed clicking on the Play video button is smaller and the thumbnail is cutout #182 (#183)

* iPhone/iPad - Icon Cards - The local video in the video pop-up cannot be played and is incorrectly displayed #184 (#185)

* fix #184: use <video> tag for video in modal
* fix modal close button
* fix override fullscreen play for safari
* refactor setting attributes

* Opening up Images will display an incorrect default state on the Image grid carousel #169 (#193)

* Hero variant for Solutions page #45 (#197)

* hero variants added

* refactored changes to alltrucks block

* comments addressed

* color confusion

* make btn color always white

* button style refactor

* margin solved

* pdp edge cases

* Tabbed Carousel variant for wheelbase #190 (#196)

* add new variant for tabbed carousel
* 190 fadeIn effect with no scroll
* 190 Fix line more than 100 chars
* 190 fix index overflow
* Figcap conditional add, default color & tab items wider
* list style none & setCarousel index-1 too

---------

Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>

* Pencil Promo block #108 (#195)

* #108 - Pencil promo and banner promo block

* #108 - Add cursor: pointer to the block

* #108 - Add pencil banner links styles

* #108 - Change link hover color to acheive better contrast

* Applied comments & each block cares by itself only

* fixed alignment issue in line 288

* fix lint issue

* Fix an issue if p Element is not present inside content

* Style issues fix

* remove an unnecessary search for h1 & its styling

* move the hover effect 1 level up & a bit of code clean up

---------

Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>

* fix alignment, add hover and focus state

* V2 Columns Block variation #133 (#186)


---------

Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: Lakshmishri <lakshmi.shri.v.a@gmail.com>
Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>

* Add "My Assets" functionality #201 (#202)

* add my assets to sidekick
* add custom viewport configurations for sidekick library

* Powertrain V2 Slider Block #147 (#200)

* add block
* add new section background color

---------

Co-authored-by: Syb <133873665+cogniSyb@users.noreply.github.com>
Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>
Co-authored-by: SantiagoHomps-NC <103571932+SantiagoHomps-NC@users.noreply.github.com>
Co-authored-by: Tomasz Dziezyk <tomasz.dziezyk@netcentric.biz>
Co-authored-by: TomaszDziezykNetcentric <125962117+TomaszDziezykNetcentric@users.noreply.github.com>
Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: taimurCognizant <150666850+taimurCognizant@users.noreply.github.com>
Co-authored-by: Lakshmishri <lakshmi.shri.v.a@gmail.com>
Co-authored-by: Marko Vukićević <139957716+markovukiceviccn@users.noreply.github.com>
This was referenced Feb 13, 2024
cogniSyb added a commit that referenced this issue Feb 26, 2024
* change url and sharepoint to upstream urls

* Release 4 (#211)

* Update fstab.yaml for redesign

* change url and sharepoint to upstream urls

* Inpage navigation is in reversed order on Firefox #173 (#178)

* fix Firefox issue with sorting
* fix naming issues
* refactor focus state, button styles
* fix overlap issue

* Hero V2 Block displays different images for mobile and desktop. #106 (#179)

* refactor naming structure
* refactor adaptive images mechanism

* Icon cards block (#181)

* hlxsites#509 Fix displaying header on dealer page

* fix done

* one trust position ix

* Embed block match NZ one

* Update feed.xml

* Fix createElement()  v1-Cards

* Update feed.xml

* Update release.yml

* columns block adapted

* icon cards working

* css clean

* adjustements

* last changes

* specific class

* btn state styling

* comments corrected

* secondary btn margin corrected

* secondary btn class added

* cleanup

---------

Co-authored-by: Tomasz Dziezyk <tomasz.dziezyk@netcentric.biz>
Co-authored-by: TomaszDziezykNetcentric <125962117+TomaszDziezykNetcentric@users.noreply.github.com>
Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: Syb <133873665+cogniSyb@users.noreply.github.com>

* The pop-up of the video displayed clicking on the Play video button is smaller and the thumbnail is cutout #182 (#183)

* iPhone/iPad - Icon Cards - The local video in the video pop-up cannot be played and is incorrectly displayed #184 (#185)

* fix #184: use <video> tag for video in modal
* fix modal close button
* fix override fullscreen play for safari
* refactor setting attributes

* Opening up Images will display an incorrect default state on the Image grid carousel #169 (#193)

* Hero variant for Solutions page #45 (#197)

* hero variants added

* refactored changes to alltrucks block

* comments addressed

* color confusion

* make btn color always white

* button style refactor

* margin solved

* pdp edge cases

* Tabbed Carousel variant for wheelbase #190 (#196)

* add new variant for tabbed carousel
* 190 fadeIn effect with no scroll
* 190 Fix line more than 100 chars
* 190 fix index overflow
* Figcap conditional add, default color & tab items wider
* list style none & setCarousel index-1 too

---------

Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>

* Pencil Promo block #108 (#195)

* #108 - Pencil promo and banner promo block

* #108 - Add cursor: pointer to the block

* #108 - Add pencil banner links styles

* #108 - Change link hover color to acheive better contrast

* Applied comments & each block cares by itself only

* fixed alignment issue in line 288

* fix lint issue

* Fix an issue if p Element is not present inside content

* Style issues fix

* remove an unnecessary search for h1 & its styling

* move the hover effect 1 level up & a bit of code clean up

---------

Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>

* fix alignment, add hover and focus state

* V2 Columns Block variation #133 (#186)


---------

Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: Lakshmishri <lakshmi.shri.v.a@gmail.com>
Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>

* Add "My Assets" functionality #201 (#202)

* add my assets to sidekick
* add custom viewport configurations for sidekick library

* Powertrain V2 Slider Block #147 (#200)

* add block
* add new section background color

---------

Co-authored-by: Syb <133873665+cogniSyb@users.noreply.github.com>
Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>
Co-authored-by: SantiagoHomps-NC <103571932+SantiagoHomps-NC@users.noreply.github.com>
Co-authored-by: Tomasz Dziezyk <tomasz.dziezyk@netcentric.biz>
Co-authored-by: TomaszDziezykNetcentric <125962117+TomaszDziezykNetcentric@users.noreply.github.com>
Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: taimurCognizant <150666850+taimurCognizant@users.noreply.github.com>
Co-authored-by: Lakshmishri <lakshmi.shri.v.a@gmail.com>
Co-authored-by: Marko Vukićević <139957716+markovukiceviccn@users.noreply.github.com>

* change url and sharepoint to upstream urls

---------

Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>
Co-authored-by: Lakshmishri <lakshmi.shri.v.a@gmail.com>
Co-authored-by: Syb <133873665+cogniSyb@users.noreply.github.com>
Co-authored-by: SantiagoHomps-NC <103571932+SantiagoHomps-NC@users.noreply.github.com>
Co-authored-by: Tomasz Dziezyk <tomasz.dziezyk@netcentric.biz>
Co-authored-by: TomaszDziezykNetcentric <125962117+TomaszDziezykNetcentric@users.noreply.github.com>
Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: taimurCognizant <150666850+taimurCognizant@users.noreply.github.com>
Co-authored-by: Marko Vukićević <139957716+markovukiceviccn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

7 participants