Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hero variant for Solutions page #45

Closed
cogniSyb opened this issue Aug 16, 2023 · 3 comments
Closed

Hero variant for Solutions page #45

cogniSyb opened this issue Aug 16, 2023 · 3 comments
Assignees
@girishdigrajkar
Labels
Solutions Spillover Trucks and segments
Milestone
MT Solutions

Comments

@cogniSyb
Copy link
Collaborator

cogniSyb commented Aug 16, 2023 •
edited
Loading

On certain pages we have a so-called secondary hero.

Make the font in the Header secondary variant white instead of black.

Tertiary Hero Design:
@DanielaPedrochevd DanielaPedrochevd added this to the MT Solutions milestone Oct 31, 2023
@DanielaPedrochevd DanielaPedrochevd mentioned this issue Nov 9, 2023
Open
@DanielaPedrochevd
Copy link
Collaborator

DanielaPedrochevd commented Jan 3, 2024 •
edited by BeckyMedlin
Loading

Agile Requirement

As a business owner, I want to achieve the following design, so that I can add this secondary variant hero in the pages that I want.

Description

Make the font in the Header secondary variant white instead of black.
Image added by editors must have the gradient effect. (Similar solution as Volvo Trucks.)

Acceptance Criteria

  • As a content editor, when I use the font in the Header secondary variant this font is white instead of black.
  • As a content editor, when I add an image, this image has a gradient effect to achieve the desired contrast.

@SantiagoHomps-NC SantiagoHomps-NC self-assigned this Jan 3, 2024
@SantiagoHomps-NC SantiagoHomps-NC mentioned this issue Jan 4, 2024
Merged
@girishdigrajkar
Copy link
Collaborator

Observation related to the secondary, Tertiary Hero for the fix ... thanks

SantiagoHomps-NC added a commit that referenced this issue Jan 10, 2024
@SantiagoHomps-NC
Hero variant for Solutions page #45 (#197)
b8854af 
* hero variants added

* refactored changes to alltrucks block

* comments addressed

* color confusion

* make btn color always white

* button style refactor

* margin solved

* pdp edge cases
@girishdigrajkar
Copy link
Collaborator

Validated and able to get the correct results. hence, marking the issue to 'Bugs Done'.
Below outstanding observations are now fixed and revalidated as passed.

Secondary Hero: Margin after Title Text “ Mack Highway” Expected: 24px ; Actual: 41px : Fixed now

Tertiary Hero: Margin after Title Text “ Mack Highway” Actual: 41px.: Fixed now

Text pixel size is 600px X 48px as expected Except for Light version where can see first line as 600X24. : Fixed now

manuel-vara added a commit that referenced this issue Jan 31, 2024
@manuel-vara @cogniSyb
@SantiagoHomps-NC @TomaszDziezykNetcentric @jonatan-lledo-netcentric @aem-code-sync @taimurCognizant @Lakshmishri @markovukiceviccn
Release 4 (#211)
f3ff901 
* Update fstab.yaml for redesign

* change url and sharepoint to upstream urls

* Inpage navigation is in reversed order on Firefox #173 (#178)

* fix Firefox issue with sorting
* fix naming issues
* refactor focus state, button styles
* fix overlap issue

* Hero V2 Block displays different images for mobile and desktop. #106 (#179)

* refactor naming structure
* refactor adaptive images mechanism

* Icon cards block (#181)

* hlxsites#509 Fix displaying header on dealer page

* fix done

* one trust position ix

* Embed block match NZ one

* Update feed.xml

* Fix createElement()  v1-Cards

* Update feed.xml

* Update release.yml

* columns block adapted

* icon cards working

* css clean

* adjustements

* last changes

* specific class

* btn state styling

* comments corrected

* secondary btn margin corrected

* secondary btn class added

* cleanup

---------

Co-authored-by: Tomasz Dziezyk <tomasz.dziezyk@netcentric.biz>
Co-authored-by: TomaszDziezykNetcentric <125962117+TomaszDziezykNetcentric@users.noreply.github.com>
Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: Syb <133873665+cogniSyb@users.noreply.github.com>

* The pop-up of the video displayed clicking on the Play video button is smaller and the thumbnail is cutout #182 (#183)

* iPhone/iPad - Icon Cards - The local video in the video pop-up cannot be played and is incorrectly displayed #184 (#185)

* fix #184: use <video> tag for video in modal
* fix modal close button
* fix override fullscreen play for safari
* refactor setting attributes

* Opening up Images will display an incorrect default state on the Image grid carousel #169 (#193)

* Hero variant for Solutions page #45 (#197)

* hero variants added

* refactored changes to alltrucks block

* comments addressed

* color confusion

* make btn color always white

* button style refactor

* margin solved

* pdp edge cases

* Tabbed Carousel variant for wheelbase #190 (#196)

* add new variant for tabbed carousel
* 190 fadeIn effect with no scroll
* 190 Fix line more than 100 chars
* 190 fix index overflow
* Figcap conditional add, default color & tab items wider
* list style none & setCarousel index-1 too

---------

Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>

* Pencil Promo block #108 (#195)

* #108 - Pencil promo and banner promo block

* #108 - Add cursor: pointer to the block

* #108 - Add pencil banner links styles

* #108 - Change link hover color to acheive better contrast

* Applied comments & each block cares by itself only

* fixed alignment issue in line 288

* fix lint issue

* Fix an issue if p Element is not present inside content

* Style issues fix

* remove an unnecessary search for h1 & its styling

* move the hover effect 1 level up & a bit of code clean up

---------

Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>

* fix alignment, add hover and focus state

* V2 Columns Block variation #133 (#186)


---------

Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: Lakshmishri <lakshmi.shri.v.a@gmail.com>
Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>

* Add "My Assets" functionality #201 (#202)

* add my assets to sidekick
* add custom viewport configurations for sidekick library

* Powertrain V2 Slider Block #147 (#200)

* add block
* add new section background color

---------

Co-authored-by: Syb <133873665+cogniSyb@users.noreply.github.com>
Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>
Co-authored-by: SantiagoHomps-NC <103571932+SantiagoHomps-NC@users.noreply.github.com>
Co-authored-by: Tomasz Dziezyk <tomasz.dziezyk@netcentric.biz>
Co-authored-by: TomaszDziezykNetcentric <125962117+TomaszDziezykNetcentric@users.noreply.github.com>
Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: taimurCognizant <150666850+taimurCognizant@users.noreply.github.com>
Co-authored-by: Lakshmishri <lakshmi.shri.v.a@gmail.com>
Co-authored-by: Marko Vukićević <139957716+markovukiceviccn@users.noreply.github.com>
cogniSyb added a commit that referenced this issue Feb 26, 2024
@manuel-vara @cogniSyb
@Lakshmishri @SantiagoHomps-NC @TomaszDziezykNetcentric @jonatan-lledo-netcentric @aem-code-sync @taimurCognizant @markovukiceviccn
Redesign release 4 (hlxsites#559)
a9933c7 
* change url and sharepoint to upstream urls

* Release 4 (#211)

* Update fstab.yaml for redesign

* change url and sharepoint to upstream urls

* Inpage navigation is in reversed order on Firefox #173 (#178)

* fix Firefox issue with sorting
* fix naming issues
* refactor focus state, button styles
* fix overlap issue

* Hero V2 Block displays different images for mobile and desktop. #106 (#179)

* refactor naming structure
* refactor adaptive images mechanism

* Icon cards block (#181)

* hlxsites#509 Fix displaying header on dealer page

* fix done

* one trust position ix

* Embed block match NZ one

* Update feed.xml

* Fix createElement()  v1-Cards

* Update feed.xml

* Update release.yml

* columns block adapted

* icon cards working

* css clean

* adjustements

* last changes

* specific class

* btn state styling

* comments corrected

* secondary btn margin corrected

* secondary btn class added

* cleanup

---------

Co-authored-by: Tomasz Dziezyk <tomasz.dziezyk@netcentric.biz>
Co-authored-by: TomaszDziezykNetcentric <125962117+TomaszDziezykNetcentric@users.noreply.github.com>
Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: Syb <133873665+cogniSyb@users.noreply.github.com>

* The pop-up of the video displayed clicking on the Play video button is smaller and the thumbnail is cutout #182 (#183)

* iPhone/iPad - Icon Cards - The local video in the video pop-up cannot be played and is incorrectly displayed #184 (#185)

* fix #184: use <video> tag for video in modal
* fix modal close button
* fix override fullscreen play for safari
* refactor setting attributes

* Opening up Images will display an incorrect default state on the Image grid carousel #169 (#193)

* Hero variant for Solutions page #45 (#197)

* hero variants added

* refactored changes to alltrucks block

* comments addressed

* color confusion

* make btn color always white

* button style refactor

* margin solved

* pdp edge cases

* Tabbed Carousel variant for wheelbase #190 (#196)

* add new variant for tabbed carousel
* 190 fadeIn effect with no scroll
* 190 Fix line more than 100 chars
* 190 fix index overflow
* Figcap conditional add, default color & tab items wider
* list style none & setCarousel index-1 too

---------

Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>

* Pencil Promo block #108 (#195)

* #108 - Pencil promo and banner promo block

* #108 - Add cursor: pointer to the block

* #108 - Add pencil banner links styles

* #108 - Change link hover color to acheive better contrast

* Applied comments & each block cares by itself only

* fixed alignment issue in line 288

* fix lint issue

* Fix an issue if p Element is not present inside content

* Style issues fix

* remove an unnecessary search for h1 & its styling

* move the hover effect 1 level up & a bit of code clean up

---------

Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>

* fix alignment, add hover and focus state

* V2 Columns Block variation #133 (#186)


---------

Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: Lakshmishri <lakshmi.shri.v.a@gmail.com>
Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>

* Add "My Assets" functionality #201 (#202)

* add my assets to sidekick
* add custom viewport configurations for sidekick library

* Powertrain V2 Slider Block #147 (#200)

* add block
* add new section background color

---------

Co-authored-by: Syb <133873665+cogniSyb@users.noreply.github.com>
Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>
Co-authored-by: SantiagoHomps-NC <103571932+SantiagoHomps-NC@users.noreply.github.com>
Co-authored-by: Tomasz Dziezyk <tomasz.dziezyk@netcentric.biz>
Co-authored-by: TomaszDziezykNetcentric <125962117+TomaszDziezykNetcentric@users.noreply.github.com>
Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: taimurCognizant <150666850+taimurCognizant@users.noreply.github.com>
Co-authored-by: Lakshmishri <lakshmi.shri.v.a@gmail.com>
Co-authored-by: Marko Vukićević <139957716+markovukiceviccn@users.noreply.github.com>

* change url and sharepoint to upstream urls

---------

Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>
Co-authored-by: Lakshmishri <lakshmi.shri.v.a@gmail.com>
Co-authored-by: Syb <133873665+cogniSyb@users.noreply.github.com>
Co-authored-by: SantiagoHomps-NC <103571932+SantiagoHomps-NC@users.noreply.github.com>
Co-authored-by: Tomasz Dziezyk <tomasz.dziezyk@netcentric.biz>
Co-authored-by: TomaszDziezykNetcentric <125962117+TomaszDziezykNetcentric@users.noreply.github.com>
Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: taimurCognizant <150666850+taimurCognizant@users.noreply.github.com>
Co-authored-by: Marko Vukićević <139957716+markovukiceviccn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@girishdigrajkar girishdigrajkar

Labels
Solutions Spillover Trucks and segments
Projects
None yet
Milestone
MT Solutions
Development

When branches are created from issues, their pull requests are automatically linked.

45-hero-variant Netcentric/vg-macktrucks-com-rd
5 participants
@SantiagoHomps-NC @girishdigrajkar @cogniSyb @BeckyMedlin @DanielaPedrochevd