Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Minor - iPhone - Chrome browser - Images Grid carousel - Opening up Images will display an incorrect default state on the Image grid carousel #169

Closed
Andrei-Boiangiu opened this issue Nov 17, 2023 · 2 comments
Assignees
Labels
Bugfix Something isn't working

Comments

@Andrei-Boiangiu
Copy link
Collaborator

When opening an Image from the Images grid carousel on the Chrome browser of an iPhone, the default state of the image in the carousel has an incorrect “inbetween slides” state

Steps to reproduce:

  1. Open https://38-images-grid-carousel--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/tdziezyk/v2/images-grid-with-modal on the Chrome browser of an iPhone
  2. Click on one of the Images from the bottom
  3. Notice the default state of the Image on the Images grid carousel

Expected result
Image on Carousel should be correctly displayed by default when clicking on one of the Images

Actual result
When opening the Image grid carousel on the Chrome browser of an iPhone there is an incorrect “inbetween slides” state displayed by default

Note: This issue has been so far identified on the iPhone - Chrome combination and even there is occuring intermitently

Tested using broswerstack: iPhone 13: Chrome

image

image

@Andrei-Boiangiu
Copy link
Collaborator Author

#38

@cogniSyb cogniSyb added the Bugfix Something isn't working label Nov 20, 2023
TomaszDziezykNetcentric pushed a commit that referenced this issue Dec 19, 2023
TomaszDziezykNetcentric pushed a commit that referenced this issue Dec 19, 2023
TomaszDziezykNetcentric pushed a commit that referenced this issue Dec 19, 2023
TomaszDziezykNetcentric pushed a commit that referenced this issue Dec 19, 2023
TomaszDziezykNetcentric pushed a commit that referenced this issue Dec 19, 2023
TomaszDziezykNetcentric pushed a commit that referenced this issue Dec 19, 2023
TomaszDziezykNetcentric pushed a commit that referenced this issue Dec 19, 2023
TomaszDziezykNetcentric pushed a commit that referenced this issue Dec 19, 2023
TomaszDziezykNetcentric pushed a commit that referenced this issue Dec 19, 2023
@girishdigrajkar
Copy link
Collaborator

Validated with URL and able to get the correct results hence, closing the defect :

image

@cogniSyb cogniSyb closed this as completed Jan 2, 2024
manuel-vara added a commit that referenced this issue Jan 31, 2024
* Update fstab.yaml for redesign

* change url and sharepoint to upstream urls

* Inpage navigation is in reversed order on Firefox #173 (#178)

* fix Firefox issue with sorting
* fix naming issues
* refactor focus state, button styles
* fix overlap issue

* Hero V2 Block displays different images for mobile and desktop. #106 (#179)

* refactor naming structure
* refactor adaptive images mechanism

* Icon cards block (#181)

* hlxsites#509 Fix displaying header on dealer page

* fix done

* one trust position ix

* Embed block match NZ one

* Update feed.xml

* Fix createElement()  v1-Cards

* Update feed.xml

* Update release.yml

* columns block adapted

* icon cards working

* css clean

* adjustements

* last changes

* specific class

* btn state styling

* comments corrected

* secondary btn margin corrected

* secondary btn class added

* cleanup

---------

Co-authored-by: Tomasz Dziezyk <tomasz.dziezyk@netcentric.biz>
Co-authored-by: TomaszDziezykNetcentric <125962117+TomaszDziezykNetcentric@users.noreply.github.com>
Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: Syb <133873665+cogniSyb@users.noreply.github.com>

* The pop-up of the video displayed clicking on the Play video button is smaller and the thumbnail is cutout #182 (#183)

* iPhone/iPad - Icon Cards - The local video in the video pop-up cannot be played and is incorrectly displayed #184 (#185)

* fix #184: use <video> tag for video in modal
* fix modal close button
* fix override fullscreen play for safari
* refactor setting attributes

* Opening up Images will display an incorrect default state on the Image grid carousel #169 (#193)

* Hero variant for Solutions page #45 (#197)

* hero variants added

* refactored changes to alltrucks block

* comments addressed

* color confusion

* make btn color always white

* button style refactor

* margin solved

* pdp edge cases

* Tabbed Carousel variant for wheelbase #190 (#196)

* add new variant for tabbed carousel
* 190 fadeIn effect with no scroll
* 190 Fix line more than 100 chars
* 190 fix index overflow
* Figcap conditional add, default color & tab items wider
* list style none & setCarousel index-1 too

---------

Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>

* Pencil Promo block #108 (#195)

* #108 - Pencil promo and banner promo block

* #108 - Add cursor: pointer to the block

* #108 - Add pencil banner links styles

* #108 - Change link hover color to acheive better contrast

* Applied comments & each block cares by itself only

* fixed alignment issue in line 288

* fix lint issue

* Fix an issue if p Element is not present inside content

* Style issues fix

* remove an unnecessary search for h1 & its styling

* move the hover effect 1 level up & a bit of code clean up

---------

Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>

* fix alignment, add hover and focus state

* V2 Columns Block variation #133 (#186)


---------

Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: Lakshmishri <lakshmi.shri.v.a@gmail.com>
Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>

* Add "My Assets" functionality #201 (#202)

* add my assets to sidekick
* add custom viewport configurations for sidekick library

* Powertrain V2 Slider Block #147 (#200)

* add block
* add new section background color

---------

Co-authored-by: Syb <133873665+cogniSyb@users.noreply.github.com>
Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>
Co-authored-by: SantiagoHomps-NC <103571932+SantiagoHomps-NC@users.noreply.github.com>
Co-authored-by: Tomasz Dziezyk <tomasz.dziezyk@netcentric.biz>
Co-authored-by: TomaszDziezykNetcentric <125962117+TomaszDziezykNetcentric@users.noreply.github.com>
Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: taimurCognizant <150666850+taimurCognizant@users.noreply.github.com>
Co-authored-by: Lakshmishri <lakshmi.shri.v.a@gmail.com>
Co-authored-by: Marko Vukićević <139957716+markovukiceviccn@users.noreply.github.com>
cogniSyb added a commit that referenced this issue Feb 26, 2024
* change url and sharepoint to upstream urls

* Release 4 (#211)

* Update fstab.yaml for redesign

* change url and sharepoint to upstream urls

* Inpage navigation is in reversed order on Firefox #173 (#178)

* fix Firefox issue with sorting
* fix naming issues
* refactor focus state, button styles
* fix overlap issue

* Hero V2 Block displays different images for mobile and desktop. #106 (#179)

* refactor naming structure
* refactor adaptive images mechanism

* Icon cards block (#181)

* hlxsites#509 Fix displaying header on dealer page

* fix done

* one trust position ix

* Embed block match NZ one

* Update feed.xml

* Fix createElement()  v1-Cards

* Update feed.xml

* Update release.yml

* columns block adapted

* icon cards working

* css clean

* adjustements

* last changes

* specific class

* btn state styling

* comments corrected

* secondary btn margin corrected

* secondary btn class added

* cleanup

---------

Co-authored-by: Tomasz Dziezyk <tomasz.dziezyk@netcentric.biz>
Co-authored-by: TomaszDziezykNetcentric <125962117+TomaszDziezykNetcentric@users.noreply.github.com>
Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: Syb <133873665+cogniSyb@users.noreply.github.com>

* The pop-up of the video displayed clicking on the Play video button is smaller and the thumbnail is cutout #182 (#183)

* iPhone/iPad - Icon Cards - The local video in the video pop-up cannot be played and is incorrectly displayed #184 (#185)

* fix #184: use <video> tag for video in modal
* fix modal close button
* fix override fullscreen play for safari
* refactor setting attributes

* Opening up Images will display an incorrect default state on the Image grid carousel #169 (#193)

* Hero variant for Solutions page #45 (#197)

* hero variants added

* refactored changes to alltrucks block

* comments addressed

* color confusion

* make btn color always white

* button style refactor

* margin solved

* pdp edge cases

* Tabbed Carousel variant for wheelbase #190 (#196)

* add new variant for tabbed carousel
* 190 fadeIn effect with no scroll
* 190 Fix line more than 100 chars
* 190 fix index overflow
* Figcap conditional add, default color & tab items wider
* list style none & setCarousel index-1 too

---------

Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>

* Pencil Promo block #108 (#195)

* #108 - Pencil promo and banner promo block

* #108 - Add cursor: pointer to the block

* #108 - Add pencil banner links styles

* #108 - Change link hover color to acheive better contrast

* Applied comments & each block cares by itself only

* fixed alignment issue in line 288

* fix lint issue

* Fix an issue if p Element is not present inside content

* Style issues fix

* remove an unnecessary search for h1 & its styling

* move the hover effect 1 level up & a bit of code clean up

---------

Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>

* fix alignment, add hover and focus state

* V2 Columns Block variation #133 (#186)


---------

Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: Lakshmishri <lakshmi.shri.v.a@gmail.com>
Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>

* Add "My Assets" functionality #201 (#202)

* add my assets to sidekick
* add custom viewport configurations for sidekick library

* Powertrain V2 Slider Block #147 (#200)

* add block
* add new section background color

---------

Co-authored-by: Syb <133873665+cogniSyb@users.noreply.github.com>
Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>
Co-authored-by: SantiagoHomps-NC <103571932+SantiagoHomps-NC@users.noreply.github.com>
Co-authored-by: Tomasz Dziezyk <tomasz.dziezyk@netcentric.biz>
Co-authored-by: TomaszDziezykNetcentric <125962117+TomaszDziezykNetcentric@users.noreply.github.com>
Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: taimurCognizant <150666850+taimurCognizant@users.noreply.github.com>
Co-authored-by: Lakshmishri <lakshmi.shri.v.a@gmail.com>
Co-authored-by: Marko Vukićević <139957716+markovukiceviccn@users.noreply.github.com>

* change url and sharepoint to upstream urls

---------

Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>
Co-authored-by: Lakshmishri <lakshmi.shri.v.a@gmail.com>
Co-authored-by: Syb <133873665+cogniSyb@users.noreply.github.com>
Co-authored-by: SantiagoHomps-NC <103571932+SantiagoHomps-NC@users.noreply.github.com>
Co-authored-by: Tomasz Dziezyk <tomasz.dziezyk@netcentric.biz>
Co-authored-by: TomaszDziezykNetcentric <125962117+TomaszDziezykNetcentric@users.noreply.github.com>
Co-authored-by: Jonatan Lledo <117984204+jonatan-lledo-netcentric@users.noreply.github.com>
Co-authored-by: aem-code-sync[bot] <aem-code-sync[bot]@users.noreply.github.com>
Co-authored-by: taimurCognizant <150666850+taimurCognizant@users.noreply.github.com>
Co-authored-by: Marko Vukićević <139957716+markovukiceviccn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants