Section metadata options: background colour & image #64 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
|
|
|
|
|
|
cogniSyb
force-pushed
the
64-section-bg
branch
from
85cd815
to
d214fe4
Compare
|
On this link https://64-section-bg--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/laura/pdp |
|
|
cogniSyb
force-pushed
the
64-section-bg
branch
from
52a18ef
to
fc9e4c5
Compare
|
cogniSyb
changed the title
cogniSyb
force-pushed
the
64-section-bg
branch
from
fc9e4c5
to
351a59e
Compare
|
markovukiceviccn
approved these changes
Oct 17, 2023
|
|
||
| .section--background-with-dots::after { | ||
| background-image: url('../../media/dots.svg'); | ||
| background-position: top right 10px; |
There was a problem hiding this comment.
Shorthand possible: background: url('../../media/dots.svg') top right 10px;
TomaszDziezykNetcentric
approved these changes
Oct 18, 2023
|
cogniSyb
added a commit
that referenced
this pull request
Nov 7, 2023
cogniSyb
added a commit
that referenced
this pull request
Nov 7, 2023
cogniSyb
added a commit
that referenced
this pull request
Nov 7, 2023
cogniSyb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #64
Test URLs:
https://develop--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/laura/pdp
https://64-section-bg--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/laura/pdp
Section metadata can contain the following styles:
gray background overlap (used for testimonial block)The section metadata can contain a background image, for columns info variant. See https://64-section-bg--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/syb/columns and how it’s done in Franklin:
