Performance optimization for primitive Dynamic***Property classes

archaius-core/src/main/java/com/netflix/config/DynamicBooleanProperty.java

@@ -23,14 +23,41 @@
  *
  */
 public class DynamicBooleanProperty extends PropertyWrapper<Boolean> {
+
+    protected volatile boolean primitiveValue;
+
     public DynamicBooleanProperty(String propName, boolean defaultValue) {
         super(propName, Boolean.valueOf(defaultValue));
+
+        // Set the initial value of the cached primitive value.
+        this.primitiveValue = chooseValue();
+
+        // Add a callback to update the cached primitive value when the property is changed.
+        this.prop.addCallback(new Runnable() {
+            @Override
+            public void run() {
+                primitiveValue = chooseValue();
+            }
+        });
     }
+
     /**
      * Get the current value from the underlying DynamicProperty
+     *
+     * @return
+     */
+    private boolean chooseValue() {
+        Boolean propValue = this.prop == null ? null : this.prop.getBoolean();
+        return propValue == null ? defaultValue : propValue.booleanValue();
+    }
+
+    /**
+     * Get the current cached value.
+     *
+     * @return
      */
     public boolean get() {
-        return prop.getBoolean(defaultValue).booleanValue();
+        return primitiveValue;
     }
     @Override
     public Boolean getValue() {

archaius-core/src/main/java/com/netflix/config/DynamicDoubleProperty.java

@@ -24,15 +24,41 @@
  *
  */
 public class DynamicDoubleProperty extends PropertyWrapper<Double> {
+
+    protected volatile double primitiveValue;
+
     public DynamicDoubleProperty(String propName, double defaultValue) {
         super(propName, Double.valueOf(defaultValue));
+
+        // Set the initial value of the cached primitive value.
+        this.primitiveValue = chooseValue();
+
+        // Add a callback to update the cached primitive value when the property is changed.
+        this.prop.addCallback(new Runnable() {
+            @Override
+            public void run() {
+                primitiveValue = chooseValue();
+            }
+        });
     }
-        
+
     /**
      * Get the current value from the underlying DynamicProperty
+     *
+     * @return
+     */
+    private double chooseValue() {
+        Double propValue = this.prop == null ? null : this.prop.getDouble(defaultValue);
+        return propValue == null ? defaultValue : propValue.doubleValue();
+    }
+
+    /**
+     * Get the current cached value.
+     *
+     * @return
      */
     public double get() {
-        return prop.getDouble(defaultValue).doubleValue();
+        return primitiveValue;
     }
 
     @Override

archaius-core/src/main/java/com/netflix/config/DynamicFloatProperty.java

@@ -23,18 +23,45 @@
  *
  */
 public class DynamicFloatProperty extends PropertyWrapper<Float> {
+
+    protected volatile float primitiveValue;
+
     public DynamicFloatProperty(String propName, float defaultValue) {
         super(propName, Float.valueOf(defaultValue));
+
+        // Set the initial value of the cached primitive value.
+        this.primitiveValue = chooseValue();
+
+        // Add a callback to update the cached primitive value when the property is changed.
+        this.prop.addCallback(new Runnable() {
+            @Override
+            public void run() {
+                primitiveValue = chooseValue();
+            }
+        });
     }
+
     /**
      * Get the current value from the underlying DynamicProperty
+     *
+     * @return
+     */
+    private float chooseValue() {
+        Float propValue = this.prop == null ? null : this.prop.getFloat(defaultValue);
+        return propValue == null ? defaultValue : propValue.floatValue();
+    }
+
+    /**
+     * Get the current cached value.
+     *
+     * @return
      */
     public float get() {
-        return prop.getFloat(defaultValue).floatValue();
+        return primitiveValue;
     }
+
     @Override
     public Float getValue() {
-        // TODO Auto-generated method stub
         return get();
     }
 }

archaius-core/src/main/java/com/netflix/config/DynamicIntProperty.java

@@ -15,8 +15,6 @@
  */
 package com.netflix.config;
 
-import com.netflix.config.PropertyWrapper;
-
 /**
  * A dynamic property whose value is an integer
  * <p>Use APIs in {@link DynamicPropertyFactory} to create instance of this class.
@@ -25,15 +23,41 @@
  *
  */
 public class DynamicIntProperty extends PropertyWrapper<Integer> {
+
+    protected volatile int primitiveValue;
+
     public DynamicIntProperty(String propName, int defaultValue) {
         super(propName, Integer.valueOf(defaultValue));
+
+        // Set the initial value of the cached primitive value.
+        this.primitiveValue = chooseValue();
+
+        // Add a callback to update the cached primitive value when the property is changed.
+        this.prop.addCallback(new Runnable() {
+            @Override
+            public void run() {
+                primitiveValue = chooseValue();
+            }
+        });
     }
-        
+
     /**
      * Get the current value from the underlying DynamicProperty
+     *
+     * @return
+     */
+    private int chooseValue() {
+        Integer propValue = this.prop == null ? null : this.prop.getInteger(defaultValue);
+        return propValue == null ? defaultValue : propValue.intValue();
+    }
+
+    /**
+     * Get the current cached value.
+     *
+     * @return
      */
     public int get() {
-        return prop.getInteger(defaultValue).intValue();
+        return primitiveValue;
     }
 
     @Override

archaius-core/src/main/java/com/netflix/config/DynamicLongProperty.java

@@ -23,20 +23,45 @@
  *
  */
 public class DynamicLongProperty extends PropertyWrapper<Long> {
+
+    protected volatile long primitiveValue;
+
     public DynamicLongProperty(String propName, long defaultValue) {
         super(propName, Long.valueOf(defaultValue));
+
+        // Set the initial value of the cached primitive value.
+        this.primitiveValue = chooseValue();
+
+        // Add a callback to update the cached primitive value when the property is changed.
+        this.prop.addCallback(new Runnable() {
+            @Override
+            public void run() {
+                primitiveValue = chooseValue();
+            }
+        });
     }
-        
+
     /**
      * Get the current value from the underlying DynamicProperty
+     *
+     * @return
+     */
+    private long chooseValue() {
+        Long propValue = this.prop == null ? null : this.prop.getLong(defaultValue);
+        return propValue == null ? defaultValue : propValue.longValue();
+    }
+
+    /**
+     * Get the current cached value.
+     *
+     * @return
      */
     public long get() {
-        return prop.getLong(defaultValue).longValue();
+        return primitiveValue;
     }
 
     @Override
     public Long getValue() {
-        // TODO Auto-generated method stub
         return get();
     }
 }

archaius-core/src/test/java/com/netflix/config/CachedPropertiesPerfTest.java

@@ -0,0 +1,87 @@
+package com.netflix.config;
+
+/**
+ * Simple benchmark impl to compare the caching of primitive boolean value in DynamicBooleanProperty with
+ * the original implementation.
+ *
+ * @author Mike Smith
+ * Date: 11/25/15
+ */
+public class CachedPropertiesPerfTest
+{
+    public static void main(String[] args)
+    {
+        try {
+            long loopCount = 4000000000l;
+
+            // Run twice.
+            runTest(loopCount);
+            runTest(loopCount);
+        }
+        catch(Exception e) {
+            e.printStackTrace();
+        }
+    }
+
+    private static void runTest(long loopCount)
+    {
+        // Warmup and then run benchmark.
+        runNewDynamicBooleanPropertyTest(10000);
+        long durationPrimitive = runNewDynamicBooleanPropertyTest(loopCount);
+
+        // Warmup and then run benchmark.
+        runOldDynamicBooleanPropertyTest(10000);
+        long durationOriginal = runOldDynamicBooleanPropertyTest(loopCount);
+
+        System.out.println("#####################");
+        System.out.println("Original DynamiceBooleanProperty totalled " + durationOriginal + " ms.");
+        System.out.println("New DynamicBooleanProperty totalled " + durationPrimitive + " ms.");
+    }
+
+    private static long runOldDynamicBooleanPropertyTest(long loopCount)
+    {
+        OriginalDynamicBooleanProperty prop = new OriginalDynamicBooleanProperty("zuul.test.cachedprops.original", true);
+
+        long startTime = System.currentTimeMillis();
+
+        for (long i=0; i<loopCount; i++) {
+            prop.get();
+        }
+
+        return System.currentTimeMillis() - startTime;
+    }
+
+    private static long runNewDynamicBooleanPropertyTest(long loopCount)
+    {
+        DynamicBooleanProperty prop =
+                new DynamicBooleanProperty("zuul.test.cachedprops.new", true);
+
+        long startTime = System.currentTimeMillis();
+
+        for (long i=0; i<loopCount; i++) {
+            prop.get();
+        }
+
+        return System.currentTimeMillis() - startTime;
+    }
+
+    /**
+     * This is a copy of the DynamicBooleanProperty class from before I made the performance optimization to it.
+     * It's here so I can still do a back-to-back comparison of performance.
+     */
+    static class OriginalDynamicBooleanProperty extends PropertyWrapper<Boolean> {
+
+        public OriginalDynamicBooleanProperty(String propName, boolean defaultValue) {
+            super(propName, Boolean.valueOf(defaultValue));
+        }
+
+        public boolean get() {
+            return prop.getBoolean(defaultValue).booleanValue();
+        }
+
+        @Override
+        public Boolean getValue() {
+            return get();
+        }
+    }
+}