Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeGen] Unable to supply arguments for fields in projection nor supply aliases #63

Closed
deadpool333999 opened this issue Feb 15, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@deadpool333999
Copy link

Inspecting the generated code, looks like there is no ability to supply arguments to fields in projections nor is there ability to supply aliases either.
https://graphql.org/learn/queries/#arguments
https://graphql.org/learn/queries/#aliases

This behavior can be reproduced by tweaking the example from the Getting started guide:
type Votes { starRating(min: Float): Float nrOfVotes: Int }
After generating for this example, there is no way to set min on the field starRating via the TicksEdgesNodeRouteVotesProjection.java methods.

@srinivasankavitha
Copy link
Contributor

We don't support this type of query currently. Will look into adding this as a new feature.

@srinivasankavitha srinivasankavitha added the enhancement New feature or request label Feb 16, 2021
@sdoxsee
Copy link

sdoxsee commented Mar 8, 2021

I believe this is a codegen issue. Should this issue be closed and linked to a new one on https://github.com/Netflix/dgs-codegen for better tracking?

@srinivasankavitha
Copy link
Contributor

Yes, sure. That is a better place to track this.

@sdoxsee
Copy link

sdoxsee commented Mar 9, 2021

@srinivasankavitha. New dgs-codegen issue created and linked so this one can be closed. Thanks!

@srinivasankavitha
Copy link
Contributor

Moved to codegen repo, closing this issue.

@sdoxsee
Copy link

sdoxsee commented Mar 12, 2021

@deadpool333999 would you be interested in reviewing Netflix/dgs-codegen#69 to see if that meets your needs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants