Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/workflows #583

Merged
merged 26 commits into from Oct 6, 2020
Merged

Feature/workflows #583

merged 26 commits into from Oct 6, 2020

Conversation

kevgliss
Copy link
Contributor

@kevgliss kevgliss commented Sep 23, 2020 •
edited

All visuals are first drafts and likely to change slightly.

/dispatch-run-workflow example modal:
2020-10-01_15-06

/dispatch-list-workflows example output:
2020-10-01_15-11

Run workflow status messages:
2020-10-01_15-14_1
2020-10-01_15-13
2020-10-01_15-14

Workflow UI:
2020-10-01_15-15

Workflow Incident Details:
2020-10-01_15-16

@lgtm-com
Copy link

lgtm-com bot commented Sep 25, 2020

This pull request introduces 4 alerts when merging 566490c into 161579b - view on LGTM.com

new alerts:

  • 2 for Use of the return value of a procedure
  • 1 for Wrong name for an argument in a call
  • 1 for Module imports itself

@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2020

This pull request introduces 6 alerts when merging fb5300e into fb498ac - view on LGTM.com

new alerts:

  • 2 for Use of the return value of a procedure
  • 2 for Wrong number of arguments in a call
  • 1 for Wrong name for an argument in a call
  • 1 for Module imports itself

@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2020

This pull request introduces 2 alerts when merging c773336 into fb498ac - view on LGTM.com

new alerts:

  • 2 for Use of the return value of a procedure

@lgtm-com
Copy link

lgtm-com bot commented Sep 30, 2020

This pull request introduces 2 alerts when merging e905295 into fb498ac - view on LGTM.com

new alerts:

  • 2 for Use of the return value of a procedure

@kevgliss kevgliss marked this pull request as ready for review October 1, 2020 22:17
@lgtm-com
Copy link

lgtm-com bot commented Oct 1, 2020

This pull request introduces 3 alerts when merging 4c0061c into 95572fb - view on LGTM.com

new alerts:

  • 2 for Use of the return value of a procedure
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Oct 2, 2020

This pull request introduces 2 alerts when merging bd90414 into 95572fb - view on LGTM.com

new alerts:

  • 2 for Use of the return value of a procedure

mvilanova
mvilanova reviewed Oct 2, 2020
View reviewed changes
Copy link
Contributor

@mvilanova mvilanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Some comments and suggestions.

src/dispatch/document/service.py Show resolved Hide resolved
src/dispatch/messaging.py Show resolved Hide resolved
src/dispatch/plugins/dispatch_slack/messaging.py Show resolved Hide resolved
src/dispatch/plugins/dispatch_slack/modals.py Outdated Show resolved Hide resolved
src/dispatch/workflow/models.py Show resolved Hide resolved
src/dispatch/workflow/service.py Outdated Show resolved Hide resolved
src/dispatch/workflow/views.py Outdated Show resolved Hide resolved
src/dispatch/workflow/views.py Outdated Show resolved Hide resolved
src/dispatch/workflow/views.py Outdated Show resolved Hide resolved
src/dispatch/workflow/views.py Outdated Show resolved Hide resolved
kevgliss and others added 2 commits October 2, 2020 11:19
@kevgliss @mvilanova
Update src/dispatch/workflow/views.py
2c55635 
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
@kevgliss @mvilanova
Update src/dispatch/workflow/views.py
6ec5dc3 
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
kevgliss and others added 6 commits October 2, 2020 11:20
@kevgliss @mvilanova
Update src/dispatch/workflow/views.py
4efc340 
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
@kevgliss @mvilanova
Update src/dispatch/workflow/views.py
06dae11 
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
@kevgliss @mvilanova
Update src/dispatch/workflow/service.py
e7e3e37 
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
@kevgliss @mvilanova
Update src/dispatch/plugins/dispatch_slack/modals.py
1c3981e 
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
@kevgliss
Adding suggestions
8dc9979
@kevgliss
Merge branch 'feature/workflows' of github.com:Netflix/dispatch into …
7f8424c 
…feature/workflows
@lgtm-com
Copy link

lgtm-com bot commented Oct 2, 2020

This pull request introduces 2 alerts when merging 7f8424c into 95572fb - view on LGTM.com

new alerts:

  • 2 for Use of the return value of a procedure

@lgtm-com
Copy link

lgtm-com bot commented Oct 2, 2020

This pull request introduces 3 alerts when merging 605b519 into d4d875d - view on LGTM.com

new alerts:

  • 2 for Use of the return value of a procedure
  • 1 for Unreachable 'except' block

@kevgliss kevgliss merged commit 4934fa7 into master Oct 6, 2020
@kevgliss kevgliss deleted the feature/workflows branch October 6, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvilanova mvilanova mvilanova left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevgliss @mvilanova