Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables evergreen notifications for documents. #660

Merged
merged 12 commits into from
Nov 12, 2020
Merged

Enables evergreen notifications for documents. #660

merged 12 commits into from
Nov 12, 2020

Conversation

kevgliss
Copy link
Contributor

@kevgliss kevgliss commented Nov 6, 2020 •
edited

Adds support for marking documents as eligible for evergreen notifications:

2020-11-09_14-17
2020-11-09_14-15
2020-11-09_15-30

@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2020

This pull request introduces 2 alerts and fixes 3 when merging 42b1dfa into 3f6d5b7 - view on LGTM.com

new alerts:

  • 1 for Use of the return value of a procedure
  • 1 for Potentially unsafe external link

fixed alerts:

  • 3 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Nov 9, 2020

This pull request introduces 2 alerts and fixes 3 when merging 046608f into 6f37dbf - view on LGTM.com

new alerts:

  • 1 for Use of the return value of a procedure
  • 1 for Potentially unsafe external link

fixed alerts:

  • 3 for Unused import

@kevgliss kevgliss marked this pull request as ready for review November 9, 2020 23:51
@lgtm-com
Copy link

lgtm-com bot commented Nov 10, 2020

This pull request introduces 3 alerts and fixes 3 when merging 61a7dd2 into 6f37dbf - view on LGTM.com

new alerts:

  • 1 for Use of the return value of a procedure
  • 1 for Unused import
  • 1 for Potentially unsafe external link

fixed alerts:

  • 3 for Unused import

forestmonster
forestmonster requested changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@forestmonster forestmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some language tweaks

kevgliss and others added 3 commits November 10, 2020 09:43
@kevgliss @forestmonster
Update src/dispatch/messaging.py
aaf5634 
Co-authored-by: Forest Monsen <forest.monsen@gmail.com>
@kevgliss @forestmonster
Update src/dispatch/static/dispatch/src/document/NewEditSheet.vue
dd899b8 
Co-authored-by: Forest Monsen <forest.monsen@gmail.com>
@kevgliss
Merge branch 'master' into feature/evergreen-reminder
a61178a
@lgtm-com
Copy link

lgtm-com bot commented Nov 10, 2020

This pull request introduces 3 alerts and fixes 3 when merging a61178a into 6f37dbf - view on LGTM.com

new alerts:

  • 1 for Use of the return value of a procedure
  • 1 for Unused import
  • 1 for Potentially unsafe external link

fixed alerts:

  • 3 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Nov 10, 2020

This pull request introduces 2 alerts and fixes 3 when merging 5a16083 into 6f37dbf - view on LGTM.com

new alerts:

  • 1 for Use of the return value of a procedure
  • 1 for Potentially unsafe external link

fixed alerts:

  • 3 for Unused import

@kevgliss kevgliss changed the title Initial work Enables evergreen notifications for documents. Nov 11, 2020
@mvilanova mvilanova mentioned this pull request Nov 12, 2020
Merged
mvilanova
mvilanova reviewed Nov 12, 2020
View reviewed changes
src/dispatch/document/models.py Show resolved Hide resolved
src/dispatch/document/scheduled.py Outdated Show resolved Hide resolved
src/dispatch/document/scheduled.py Outdated Show resolved Hide resolved
src/dispatch/document/scheduled.py Outdated Show resolved Hide resolved
src/dispatch/document/service.py Show resolved Hide resolved
src/dispatch/document/service.py Outdated Show resolved Hide resolved
@kevgliss @mvilanova
Update src/dispatch/document/scheduled.py
c8ac9ba 
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
@lgtm-com
Copy link

lgtm-com bot commented Nov 12, 2020

This pull request introduces 2 alerts and fixes 3 when merging c8ac9ba into 6f37dbf - view on LGTM.com

new alerts:

  • 1 for Use of the return value of a procedure
  • 1 for Potentially unsafe external link

fixed alerts:

  • 3 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Nov 12, 2020

This pull request introduces 2 alerts and fixes 3 when merging f4ba7cf into 6f37dbf - view on LGTM.com

new alerts:

  • 1 for Use of the return value of a procedure
  • 1 for Potentially unsafe external link

fixed alerts:

  • 3 for Unused import

@kevgliss kevgliss merged commit 2481dfa into master Nov 12, 2020
@kevgliss kevgliss deleted the feature/evergreen-reminder branch November 12, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvilanova mvilanova mvilanova left review comments

@forestmonster forestmonster forestmonster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevgliss @forestmonster @mvilanova