-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RxJS as a dependency #50
Comments
Hahahahahahahahahahahahahah im dying help call 911 hahahahahahaa |
freshly installing this addon also did not include Rx. I needed to do a |
This should be cleared up now. (The meta issue of rxjs not installing properly) |
Technically it's not :p this was to remove RxJS as a dependency entirely of nf-graph since it's a rather large lib for what we're using it for. As discussed, it's OK to punt on this for now, until outside contributors care enough. But I'd prefer this ticket left open since it is indeed not ideal. I'll let it be your call, but that's IMO. |
Meh. Okay. |
<3 |
I'm closing this as it's not a priority for us, or seemingly anyone else at the moment. I'm happy to take PRs around it, of course. |
Needing to pull in RxJS via RxEmber (or ember-cli-rx) seems very unnecessary and boatful. The current places it's used seem very easy to do without Rx and would save consumers significant file size.
The text was updated successfully, but these errors were encountered: