Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RxJS as a dependency #50

Closed
jayphelps opened this issue Apr 29, 2015 · 9 comments
Closed

Remove RxJS as a dependency #50

jayphelps opened this issue Apr 29, 2015 · 9 comments
Milestone

Comments

@jayphelps
Copy link
Member

Needing to pull in RxJS via RxEmber (or ember-cli-rx) seems very unnecessary and boatful. The current places it's used seem very easy to do without Rx and would save consumers significant file size.

@jayphelps jayphelps added this to the 1.0.0 milestone Apr 29, 2015
@benlesh
Copy link
Contributor

benlesh commented Apr 29, 2015

Needing to pull in RxJS via RxEmber (or ember-cli-rx) seems very unnecessary and boatful.

Boatful

@jayphelps
Copy link
Member Author

Hahahahahahahahahahahahahah im dying help call 911 hahahahahahaa

@SirZach
Copy link

SirZach commented May 5, 2015

freshly installing this addon also did not include Rx. I needed to do a npm install --save-dev ember-cli-rx and an bower install --save-dev rxjs for it to work.

@jayphelps
Copy link
Member Author

@SirZach Yep, it's not here but it needs to be. PR to fix: #56

@benlesh
Copy link
Contributor

benlesh commented May 6, 2015

This should be cleared up now. (The meta issue of rxjs not installing properly)

@benlesh benlesh closed this as completed May 6, 2015
@jayphelps
Copy link
Member Author

Technically it's not :p this was to remove RxJS as a dependency entirely of nf-graph since it's a rather large lib for what we're using it for. As discussed, it's OK to punt on this for now, until outside contributors care enough. But I'd prefer this ticket left open since it is indeed not ideal. I'll let it be your call, but that's IMO.

@benlesh
Copy link
Contributor

benlesh commented May 6, 2015

Meh. Okay.

@benlesh benlesh reopened this May 6, 2015
@jayphelps
Copy link
Member Author

<3

@benlesh
Copy link
Contributor

benlesh commented Jul 21, 2015

I'm closing this as it's not a priority for us, or seemingly anyone else at the moment. I'm happy to take PRs around it, of course.

@benlesh benlesh closed this as completed Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants