Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icicle layout #8

Closed
brendangregg opened this issue Apr 4, 2018 · 2 comments · Fixed by #64
Closed

icicle layout #8

brendangregg opened this issue Apr 4, 2018 · 2 comments · Fixed by #64
Assignees
Labels
enhancement New feature or request

Comments

@brendangregg
Copy link
Contributor

There could be a button on the flame graph view to switch it to icicle layout. This could be sticky, and/or configured via a settings page, so it always did it this way. I'm not sure what to call the button: I guess the two layout orderings are "flame" and "icicle". (Note that there's also a different layout type, sunburst, which we could also switch to, but that's changing the type of visualization rather than just the ordering; I'll file a separate ticket).

Adding this feature probably means adding code to https://github.com/spiermar/d3-flame-graph .

@brendangregg brendangregg added the enhancement New feature or request label Apr 4, 2018
@spiermar spiermar added this to the 0.2 milestone Apr 6, 2018
@spiermar spiermar self-assigned this Apr 6, 2018
@bahtiyarkaba
Copy link
Contributor

The flame-graph can be configured with an inverted flag.
I have something done with it. I'll submit a PR.
Please assign the issue to me if that sounds ok.

@spiermar
Copy link
Contributor

spiermar commented Dec 8, 2018

@bahtiyarkaba I can't assign the issue to you because the rights on the GitHub project, but feel free to submit a PR and I'll review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants