Merge pull request #4 from Netflix/config-ports

make host and port for metadata service configurable
Netflix · Jan 28, 2020 · 55710a0 · 55710a0
2 parents 334d2c7 + 653de0b
commit 55710a0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -4,7 +4,7 @@ services:
     image: "metadata_service:latest"
     container_name: "metadata_service"
     ports:
-      - "5004:5004"
+      - "${MF_METADATA_PORT:-8080}:${MF_METADATA_PORT:-8080}"
     volumes:
       - .:/code
     environment:
@@ -13,6 +13,8 @@ services:
       - MF_METADATA_DB_USER=postgres
       - MF_METADATA_DB_PSWD=postgres
       - MF_METADATA_DB_NAME=postgres
+      - MF_METADATA_PORT=${MF_METADATA_PORT:-8080}
+      - MF_METADATA_HOST=${MF_METADATA_HOST:-0.0.0.0}
     links:
       - db
   db:

diff --git a/metadata_service/server.py b/metadata_service/server.py
@@ -1,4 +1,5 @@
 import asyncio
+import os
 
 from aiohttp import web
 from aiohttp_swagger import *
@@ -36,7 +37,9 @@ def app(loop=None):
     loop = asyncio.get_event_loop()
     the_app = app(loop)
     handler = the_app.make_handler()
-    f = loop.create_server(handler, "0.0.0.0", 8080)
+    port = os.environ.get("MF_METADATA_PORT", 8080)
+    host = str(os.environ.get("MF_METADATA_HOST", "0.0.0.0"))
+    f = loop.create_server(handler, host, port)
 
     srv = loop.run_until_complete(f)
     print("serving on", srv.sockets[0].getsockname())