This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Lock Down FUSE #165
Merged
Lock Down FUSE #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=========================================
+ Coverage 33.56% 34.06% +0.5%
=========================================
Files 63 64 +1
Lines 7588 7629 +41
=========================================
+ Hits 2547 2599 +52
+ Misses 4734 4720 -14
- Partials 307 310 +3
|
Pull Request Test Coverage Report for Build 1888
💛 - Coveralls |
Merged
fabiokung
approved these changes
Aug 17, 2018
| return err | ||
| } | ||
| if fuseEnabled || c.TitusInfo.GetAllowNestedContainers() { | ||
| if _, ok := addedCapabilities["SYS_ADMIN"]; !ok { |
There was a problem hiding this comment.
minor: extract "SYS_ADMIN" to a const
| } | ||
| // We can do this here because nested containers can do everything fuse containers can | ||
| if c.TitusInfo.GetAllowNestedContainers() { | ||
| apparmorProfile = "docker-nested" |
There was a problem hiding this comment.
do the nested apparmor and seccomp profiles include everything that's in the fuse ones? (in case both FUSE && nestedContainers is enabled for a task)
There was a problem hiding this comment.
@fabiokung Yeah, I thought the comment indicated that: // We can do this here because nested containers can do everything fuse containers can -- The capabilities of nested containers are a superset of fuse containers.
There was a problem hiding this comment.
ugh, I missed that comment. LGTM
|
@fabiokung The only thing the FUSE profiles have beyond the default Docker profile are mounting. |
This introduces a new seccomp policy and apparmor policy meant to allow containers which need FUSE to use FUSE, without getting all of the scary capabilities that nested containers need.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.