This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
IPv6 #167
Merged
IPv6 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1899
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
=========================================
- Coverage 34.06% 33.8% -0.27%
=========================================
Files 64 64
Lines 7629 7765 +136
=========================================
+ Hits 2599 2625 +26
- Misses 4720 4822 +102
- Partials 310 318 +8
|
|
This PR is based on #165, because that has some API improvements and some testing bits that were added. Once that gets merged, I'll rebase on master to clean up the diff. |
This optionally allows users to allocate an IPv6 address, and assigns the full interface worth of IPv6 addresses at boot time.
|
PTAL. |
fabiokung
approved these changes
Aug 17, 2018
| return err | ||
| } | ||
| if ip6 != nil { | ||
| // Amazon only gives out /128s |
| } | ||
| defer configLock.Unlock() | ||
|
|
||
| iface, err := ctx.Cache.DescribeInterface(ctx, networkinterface.InterfaceID) |
There was a problem hiding this comment.
do we assume each interface will always have enough IPv6s? A short comment about how we expect to allocate IPs to each ENI would be good here
|
Unfortunately, this patchset is much messier than intended, because it moves around a lot of code in place. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.