Implement DictNew hint #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
TAdev0
approved these changes
May 15, 2024
cicr99
reviewed
May 23, 2024
cicr99
approved these changes
May 24, 2024
har777
added a commit
that referenced
this pull request
Jun 12, 2024
* Add basic skeleton * Implement DefaultDictNew * Add tests * Implement DefaultRead * Implement DictWrite * Add simple integration test * Update dict integration test * Update dict integration test * Fix imports * Fix imports * Implement DictUpdate * Add comments + minor changes * Remove unnecessary ctx init * Add comment * Add comment * Clean up dict integration test * Clean up dict integration test * Clean up dict integration test * Clean up dict integration test * Add comment * Treat dicts in zero hints differently * Remove accidental newline * Fix ignoring err message * Remove some unnecessary code from tests * Update implementation * Fix typo * Fix typo * Fix typo * Improved comments * Add credit comment * Add better comments * Add better comments * Add better comments * Remove unused operand * Fix freeOffset bug + add tests * Update test * Fix tests * Add and use zeroDictInScopeEquals test util * Update test * Implement DictNew hint (#351) * Add initial skeleton * Implement DictNew hint * Move dictionary manager to scope * Fix lint errir * Add GetDictionaryManager util * Change return signature * Fix pointer issue * Clean up some tests * Add comment * Reuse context dict manager * Fix some comments * Add better comments * Fix bad comment ident * Add DictAccessSize constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #288