Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create a separate command to run benchmarks #526

Closed
TAdev0 opened this issue Jul 16, 2024 · 5 comments · Fixed by #597
Closed

feat: create a separate command to run benchmarks #526

TAdev0 opened this issue Jul 16, 2024 · 5 comments · Fixed by #597
Assignees
Labels
Difficulty: easy Easy - good first issue enhancement New feature or request good first issue Good for newcomers

Comments

@TAdev0
Copy link
Member

TAdev0 commented Jul 16, 2024

Currently, benchmarks are run each time we do make integration . This lead to the txt file being overwritten again and again.

@TAdev0 TAdev0 added enhancement New feature or request good first issue Good for newcomers Difficulty: easy Easy - good first issue labels Jul 16, 2024
@fmmesen
Copy link
Contributor

fmmesen commented Jul 16, 2024

Hello! I'd like to work on this

@EmmanuelAR
Copy link
Contributor

EmmanuelAR commented Jul 16, 2024

Hello @TAdev0

My name is Emmanuel, a software developer from Costa Rica. I am already working on this repository and would be happy to assist with this task. I will review the current implementation and create a separate command to run the benchmarks.

Please let me know if this is acceptable.

Best regards,
Emmanuel 😁

@TAdev0
Copy link
Member Author

TAdev0 commented Jul 16, 2024

Hi !
@fmmesen you answered first, i guess i'll assign you.
Can you work on it and propose a PR before the weekend? otherwise you can work on it @EmmanuelAR so that we can merge this feature before end of week

@fmmesen
Copy link
Contributor

fmmesen commented Jul 17, 2024

Hello @TAdev0 thank you! I'll start it today

@TAdev0
Copy link
Member Author

TAdev0 commented Jul 23, 2024

hi @fmmesen any update? would be nice to merge this quickly so that we dont overwrite the benchmark file all the time with all the hints being currently implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: easy Easy - good first issue enhancement New feature or request good first issue Good for newcomers
Projects
None yet
3 participants