Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added flag solution to avoid Benchmark files #597

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Added flag solution to avoid Benchmark files #597

merged 3 commits into from
Jul 24, 2024

Conversation

fmmesen
Copy link
Contributor

@fmmesen fmmesen commented Jul 23, 2024 •
edited
Loading

Resolves #526

@fmmesen fmmesen mentioned this pull request Jul 23, 2024
Closed
TAdev0
TAdev0 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@TAdev0 TAdev0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

har777
har777 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@har777 har777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

TAdev0
TAdev0 approved these changes Jul 24, 2024
View reviewed changes
integration_tests/cairozero_test.go Outdated Show resolved Hide resolved
@TAdev0 TAdev0 merged commit a1a9432 into NethermindEth:main Jul 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@har777 har777 har777 approved these changes

@TAdev0 TAdev0 TAdev0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: create a separate command to run benchmarks
3 participants
@fmmesen @har777 @TAdev0