Cairo0 unsafe keccak hint #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaksymMalicki
commented
Apr 21, 2024
Closed
har777
reviewed
May 7, 2024
|
Currently the NewLegacyKeccak256() from the https://pkg.go.dev/golang.org/x/crypto/sha3 is used, which is also used in the go-ethereum crypto package. Alternatively, we could use this package, which is 10x faster on the benchmarks, than the package used in lambdaclass golang-vm. |
|
@cicr99 @rodrigo-pino what do you think? Why not using a faster implementation ? |
|
Actually after some research, the benchmarks aren't that better than the official goland lib for sha3 and it's not maintaned, so I think we should stick to what we are using currently |
TAdev0
suggested changes
Jun 6, 2024
har777
reviewed
Jun 6, 2024
cicr99
reviewed
Jun 7, 2024
cicr99
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.