Feat DivModNSafeDivPlusOne hint (ec hint)

[danielcdz]

Summary

Closes #527
Closes #532

[TAdev0]

@danielcdz just went through your PR quickly. It looks good, indeed all variables are *big.Int in scope, assigned in DivModNPackedDivmodV1 hint .

can you also add in cairo_zero_hint_tests folder a copy of this file ?

https://github.com/lambdaclass/cairo-vm/blob/db7fff18c9c1312024ebf4119fcdfeba23657b12/cairo_programs/div_mod_n.cairo#L29

you can run it with make integration command, which will check whether runnning this program with our vm and python one produces the same memory and trace files or not.

[danielcdz]

Hey @TAdev0, when I run make integration I get these errors:

Do you know how I can solve those issues? I already have installed the cairo-compile command

[TAdev0]

Mmh don't know. Can you use Cairo compile and Cairo run without issue? Maybe Python version ? Did you follow the read me to install everything properly

[danielcdz]

Mmh don't know. Can you use Cairo compile and Cairo run without issue? Maybe Python version ? Did you follow the read me to install everything properly

I found what the issue was, I forgot to activate the python venv where I have installed the cairo 0 compiler dependencies

[danielcdz]

@TAdev0 Now I have this error:

Is related to the hint implementation in Go? or what does it means exactly 🤔

[TAdev0]

Can you successfully run all other integration tests ? If no , it's a setup issue

[danielcdz]

@TAdev0 Here is a better view to the results:

I think other integration test are running as expected

[danielcdz]

I changed the name of the new file to .small.cairo and now It returns this:

[TAdev0]

OOOh thats perfect!!

https://github.com/lambdaclass/cairo-vm/blob/db7fff18c9c1312024ebf4119fcdfeba23657b12/cairo_programs/div_mod_n.cairo#L29

this is because we also miss this hint :

    %{
        from starkware.cairo.common.cairo_secp.secp_utils import pack
        from starkware.python.math_utils import div_mod, safe_div

        a = pack(ids.a, PRIME)
        b = pack(ids.b, PRIME)
        value = res = div_mod(a, b, N)
    %}

but your hint works

[TAdev0]

@danielcdz can you also work on this hint and add it to this PR?

#532

so that the integration test :
https://github.com/lambdaclass/cairo-vm/blob/db7fff18c9c1312024ebf4119fcdfeba23657b12/cairo_programs/div_mod_n.cairo

will work entirely

[danielcdz]

@TAdev0 for sure!

[danielcdz]

@TAdev0 All the integration tests are passing now!

[TAdev0]

great work overall @danielcdz !!!
Just left a few minor comments and then we merge !

[TAdev0]

@danielcdz can you resolve conflicts before final review?

[TAdev0]

You still need to add value variable in scope. Here it works because as we saw there are 2 hints in a row but the first one is only used to import N and actually adds value variable in scope, it's second one that is actually tested (the one you implemented). Yours should add value in scope as well (and overwrite the previous one in the test)

What I meant in dm is that you should create a copy of the variable you assign to res , and assign it to value

[TAdev0]

@danielcdz you can simply use new(big.Int) and BigInt method to make a local copy instead of doing the computation 2 times