Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SubscribeNewHeads to the synchronizer #1374

Closed
joshklop opened this issue Oct 25, 2023 · 0 comments · Fixed by #1373
Closed

Move SubscribeNewHeads to the synchronizer #1374

joshklop opened this issue Oct 25, 2023 · 0 comments · Fixed by #1373
Assignees
@joshklop
Labels
Refactor RPC JSON RPC API

Comments

@joshklop
Copy link
Contributor

By letting the synchronizer control when headers are emitted, it is easier to ensure they are only emitted when we actually store/revert blocks them successfully.

Furthermore, it restricts dynamism to the synchronizer, allowing the blockchain to function exclusively as a database wrapper.
@joshklop joshklop added RPC JSON RPC API Refactor labels Oct 25, 2023
@joshklop joshklop self-assigned this Oct 25, 2023
@joshklop joshklop linked a pull request Oct 25, 2023 that will close this issue
Move subscription to synchronizer #1373
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshklop joshklop

Labels
Refactor RPC JSON RPC API
Projects
[Nubia] Juno
Status: Ready For Testing
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move subscription to synchronizer NethermindEth/juno
1 participant
@joshklop