Move subscription to synchronizer #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshklop
force-pushed
the
joshklop/subs-to-sync
branch
from
e1267c4
to
f56adac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1373 +/- ##
==========================================
+ Coverage 73.69% 73.70% +0.01%
==========================================
Files 80 80
Lines 8709 8706 -3
==========================================
- Hits 6418 6417 -1
+ Misses 1800 1798 -2
Partials 491 491
☔ View full report in Codecov by Sentry. |
joshklop
force-pushed
the
joshklop/subs-to-sync
branch
from
f56adac
to
f42897d
Compare
omerfirmak
reviewed
Oct 26, 2023
joshklop
force-pushed
the
joshklop/subs-to-sync
branch
from
f42897d
to
6d92381
Compare
joshklop
force-pushed
the
joshklop/subs-to-sync
branch
from
6d92381
to
f95350c
Compare
omerfirmak
reviewed
Oct 27, 2023
joshklop
force-pushed
the
joshklop/subs-to-sync
branch
2 times, most recently
from
884cffa
to
ecd8314
Compare
In the words of one wise engineer: "We could make blockchain just a DB and move all the moving parts to sync."
omerfirmak
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.