Refactor rpc handlers and tests #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1768 +/- ##
==========================================
- Coverage 74.81% 74.53% -0.29%
==========================================
Files 90 96 +6
Lines 8177 8177
==========================================
- Hits 6118 6095 -23
- Misses 1543 1565 +22
- Partials 516 517 +1 ☔ View full report in Codecov by Sentry. |
rianhughes
reviewed
Mar 27, 2024
rianhughes
reviewed
Mar 27, 2024
rianhughes
reviewed
Mar 27, 2024
rianhughes
reviewed
Mar 27, 2024
rianhughes
reviewed
Mar 28, 2024
pnowosie
force-pushed
the
pnowosie/refactor-rpc-handlers-and-tests
branch
from
ce7d56a
to
255e1d4
Compare
rianhughes
reviewed
Mar 29, 2024
pnowosie
force-pushed
the
pnowosie/refactor-rpc-handlers-and-tests
branch
from
255e1d4
to
6b98993
Compare
rianhughes
approved these changes
Mar 29, 2024
pnowosie
force-pushed
the
pnowosie/refactor-rpc-handlers-and-tests
branch
from
6b98993
to
3322f60
Compare
pnowosie
force-pushed
the
pnowosie/refactor-rpc-handlers-and-tests
branch
from
3322f60
to
d5ec5cf
Compare
kirugan
reviewed
Apr 8, 2024
kirugan
approved these changes
Apr 8, 2024
pnowosie
force-pushed
the
pnowosie/refactor-rpc-handlers-and-tests
branch
2 times, most recently
from
cca5653
to
aa06293
Compare
All handlers and related helper methods was moved from `rpc/handlers` to the corresponding "category" file, e.g. block, transaction, trace... Handlers tests were refactor the same way. I introduced new files in `rpc/` folder: - `chain.go` - with `ChainId` handler - `class.go` - `Class*` handlers - `contract.go` - `Nonce` & `StorageAt` - `estimate_fee.go` - `helpers.go` - which contains helper functionality used in more than one "category".
pnowosie
force-pushed
the
pnowosie/refactor-rpc-handlers-and-tests
branch
from
aa06293
to
4ab9c04
Compare
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1750
All handlers and related helper methods was moved from
rpc/handlersto the corresponding "category" file, e.g. block, transaction, trace...Handlers tests were refactor the same way.
I introduced new files in
rpc/folder:chain.go- withChainIdhandlerclass.go-Class*handlerscontract.go-Nonce&StorageAtestimate_fee.gorpc/helpers.gowhich contains helper functionality used in more than one "category".