-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO_NOT_MERGE Exercise 6 #1879
base: main
Are you sure you want to change the base?
DO_NOT_MERGE Exercise 6 #1879
Conversation
sync/sync.go
Outdated
getBlockURL := fmt.Sprintf("https://alpha-sepolia.starknet.io/feeder_gateway/get_block?blockNumber=%d", blockNumber) | ||
blockResponse, err := http.Get(getBlockURL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use the starknetData interface? Adapting the types manually is a good exercise though
sync/sync.go
Outdated
default: | ||
s.log.Infow("Fetching from feeder") | ||
blocks, stateUpdate, blockCommitments := s.getBlockNumberDetails(uint64(s.latestBlockHeight)) | ||
newClass, _ := s.fetchUnknownClasses(syncCtx, &stateUpdate) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should handle the error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to fix this through the manually, if it doesn't work I will switch to the starknetdata interface as you mentioned above!
I get it now, stateUpdate is null. That is why the memory leak error
Generally it looks pretty good, although I would recommend fixing the tests. |
Hey @rianhughes, smoke test (syncing first 100 blocks) are working 🎉, but there are some issues I would like to highlight
Should I try fixing these or move on? PS: I also added
|
New Sync package using feeder gateway