Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing From field to rpc.MsgToL1 #908

Merged
merged 1 commit into from Jul 12, 2023
Merged

Conversation

omerfirmak
Copy link
Contributor

No description provided.

Copy link
Contributor

@IronGauntlets IronGauntlets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suprised we missed this

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.17 🎉

Comparison is base (9a2a752) 72.60% compared to head (d65a512) 72.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
+ Coverage   72.60%   72.77%   +0.17%     
==========================================
  Files          58       58              
  Lines        6037     6038       +1     
==========================================
+ Hits         4383     4394      +11     
+ Misses       1281     1274       -7     
+ Partials      373      370       -3     
Impacted Files Coverage Δ
rpc/transaction.go 18.18% <ø> (ø)
rpc/handlers.go 73.57% <100.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@omerfirmak omerfirmak merged commit c7ffb9b into main Jul 12, 2023
8 checks passed
@omerfirmak omerfirmak deleted the omerfirmak/fix-missing-from branch July 12, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants