Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme update for Indexer #25

Closed
wants to merge 2 commits into from
Closed

Conversation

taco-paco
Copy link
Contributor

No description provided.

Copy link
Contributor

@Hyodar Hyodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some quick discussions - feel free to resolve them yourself and merge.

Comment on lines +26 to +27
$ cargo run --release -- --home-dir ~/.near/localnet/ run --da-contract-ids "your.da1.near" \
--rollup-ids 1 --rmq-address "amqp://rmq:rmq@127.0.0.1:5672/%2f"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ cargo run --release -- --home-dir ~/.near/localnet/ run --da-contract-ids "your.da1.near" \
--rollup-ids 1 --rmq-address "amqp://rmq:rmq@127.0.0.1:5672/%2f"
$ cargo run --release -- --home-dir ~/.near/localnet/ run --da-contract-ids "your.da1.near" \
--rollup-ids 1 --rmq-address "amqp://rmq:rmq@127.0.0.1:5672"

What should be this %2f?

export NEAR_ENV="local"
export NEAR_CLI_LOCALNET_NETWORK_ID="localnet"
export NEAR_CLI_LOCALNET_KEY_PATH="/path/to/.near/localnet/validator_key.json"
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to also include NEAR_HELPER_ACCOUNT=near

@Hyodar
Copy link
Contributor

Hyodar commented Jun 6, 2024

Outdated, closing

@Hyodar Hyodar closed this Jun 6, 2024
@Hyodar Hyodar deleted the feat/indexer/update-readme branch July 22, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants