Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
In some cases, geth's
types.Block
are copied - mostly because of copying ourBlockData
instances. This is not being problematic in any sense since these locks aren't being used, but it's a small fix anyway.New Behavior
BlockData
now includes atypes.Block
as a pointer, which is even more ideal considering how much data that struct holds. Thus, no copies even when copyingBlockData
, which should still be okay.Breaking Changes
Not a breaking change.