Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancun error with BLOBBASEFEE #7059

Closed
holiman opened this issue May 22, 2024 · 1 comment · Fixed by #7043
Closed

Cancun error with BLOBBASEFEE #7059

holiman opened this issue May 22, 2024 · 1 comment · Fixed by #7043

Comments

@holiman
Copy link
Contributor

holiman commented May 22, 2024

Previously reported via https://gist.github.com/holiman/a833485f09445201787f88f0fdb55133 , re nethtest 1.26.0-unstable+4d1bebe48c74c9c42197ba6de514f9de96d9642f

Still happening in nethtest 1.27.0-unstable+927f1d4a92ea58472634fbd23209b952c7420ff8


It seems like nethermind suddenly forgot (at least in statetests) that blobbasefee is a Cancun opcode. Very odd.

Nethermind

root@5ef08fb2382f:/# /neth/nethtest  --trace -m -i /fuzztmp/00000027-mixed-0.json.min 
{"pc":0,"op":96,"gas":"0xade","gasCost":"0x3","memSize":0,"stack":[],"depth":1,"refund":0,"opname":"PUSH1","error":""}
{"pc":2,"op":96,"gas":"0xadb","gasCost":"0x3","memSize":0,"stack":["0x9a"],"depth":1,"refund":0,"opname":"PUSH1","error":""}
{"pc":4,"op":61,"gas":"0xad8","gasCost":"0x2","memSize":0,"stack":["0x9a","0xd"],"depth":1,"refund":0,"opname":"RETURNDATASIZE","error":""}
{"pc":5,"op":74,"gas":"0xad6","gasCost":"0x0","memSize":0,"stack":["0x9a","0xd","0x0"],"depth":1,"refund":0,"opname":"BLOBBASEFEE","error":"BadInstruction"}
{"output":"0x","gasUsed":"0xade","time":119.9092,"error":"BadInstruction"}
{"stateRoot":"0x522ab8d397006d4466bdf98dfcc9fb7f2dce50b84ee5fbfffdb046d28d40380e"}
[
  {
    "name": "00000027-mixed-0_d0g0v0_",
    "pass": false,
    "fork": "Cancun",
    "timeInMs": 119.9092,
    "stateRoot": "0x522ab8d397006d4466bdf98dfcc9fb7f2dce50b84ee5fbfffdb046d28d40380e"
  }

Geth

root@5ef08fb2382f:/# /gethvm --json statetest /fuzztmp/00000027-mixed-0.json.min 
{"pc":0,"op":96,"gas":"0xade","gasCost":"0x3","memSize":0,"stack":[],"depth":1,"refund":0,"opName":"PUSH1"}
{"pc":2,"op":96,"gas":"0xadb","gasCost":"0x3","memSize":0,"stack":["0x9a"],"depth":1,"refund":0,"opName":"PUSH1"}
{"pc":4,"op":61,"gas":"0xad8","gasCost":"0x2","memSize":0,"stack":["0x9a","0xd"],"depth":1,"refund":0,"opName":"RETURNDATASIZE"}
{"pc":5,"op":74,"gas":"0xad6","gasCost":"0x2","memSize":0,"stack":["0x9a","0xd","0x0"],"depth":1,"refund":0,"opName":"BLOBBASEFEE"}
{"pc":6,"op":22,"gas":"0xad4","gasCost":"0x3","memSize":0,"stack":["0x9a","0xd","0x0","0x1"],"depth":1,"refund":0,"opName":"AND"}
{"pc":7,"op":0,"gas":"0xad1","gasCost":"0x0","memSize":0,"stack":["0x9a","0xd","0x0"],"depth":1,"refund":0,"opName":"STOP"}
{"output":"","gasUsed":"0xd"}
{"stateRoot": "0x09123bce4bede3cb61aaea9e42bccdf84ff48664ab88480199e20b25b8bc855c"}
[
  {
    "name": "00000027-mixed-0",
    "pass": false,
    "stateRoot": "0x09123bce4bede3cb61aaea9e42bccdf84ff48664ab88480199e20b25b8bc855c",
    "fork": "Cancun",
    "error": "post state root mismatch: got 09123bce4bede3cb61aaea9e42bccdf84ff48664ab88480199e20b25b8bc855c, want 0000000000000000000000000000000000000000000000000000000000000000"
  }
]

Statetest

{
  "00000027-mixed-0": {
    "env": {
      "currentCoinbase": "b94f5374fce5edbc8e2a8697c15331677e6ebf0b",
      "currentDifficulty": "0x200000",
      "currentRandom": "0x0000000000000000000000000000000000000000000000000000000000200000",
      "currentGasLimit": "0x26e1f476fe1e22",
      "currentNumber": "0x1",
      "currentTimestamp": "0x3e8",
      "previousHash": "0x044852b2a670ade5407e78fb2863c51de9fcb96542a07186fe3aeda6bb8a116d",
      "currentBaseFee": "0x10"
    },
    "pre": {
      "0x00000000000000000000000000000000000000f1": {
        "code": "0x609a600d3d4a16",
        "storage": {},
        "balance": "0x0",
        "nonce": "0x0"
      },
      "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b": {
        "code": "0x",
        "storage": {},
        "balance": "0xffffffffff",
        "nonce": "0x0"
      }
    },
    "transaction": {
      "gasPrice": "0x10",
      "nonce": "0x0",
      "to": "0x00000000000000000000000000000000000000f1",
      "data": [
        "0x1e98a349c58ad922d645a0158d051621b4e1cfedb5d6d520122270ef5354c5a6fd3cc59f6dd92bdccd11ca9615101a75e08ea869d4d65d90f2c2856a4921815aefea1fceea9c8098e8ae5323"
      ],
      "gasLimit": [
        "0x61a6"
      ],
      "value": [
        "0x27860f"
      ],
      "sender": "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b",
      "secretKey": "0x45a915e4d060149eb4365960e6a7a45f334393093061116b197e3240065ff2d8"
    },
    "out": "0x",
    "post": {
      "Cancun": [
        {
          "hash": "0x0000000000000000000000000000000000000000000000000000000000000000",
          "logs": "0x0000000000000000000000000000000000000000000000000000000000000000",
          "indexes": {
            "data": 0,
            "gas": 0,
            "value": 0
          }
        }
      ]
    }
  }
}
@MarekM25
Copy link
Contributor

MarekM25 commented May 24, 2024

@holiman, it should be resolved now: #7043 Please reopen if you still encounter any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants