Implementation trace get #3436

kjazgar · 2021-09-21T12:12:29Z

Fixes | Closes | Resolves #

Changes:

Implementation of trace_get in TraceRpcModule and changes in trace_transaction.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update
Code style update (formatting, renaming)
Refactoring (no functional changes, no api changes)
Build related changes
Other (please describe):

Testing

Requires testing

Yes
No

In case you checked yes, did you write tests??

Yes
No

# Conflicts: # src/Nethermind/Nethermind.JsonRpc.Test/Modules/TraceRpcModuleTests.cs

# Conflicts: # src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs

…dule # Conflicts: # src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs

…e_get

LukaszRozmej · 2021-09-22T15:23:51Z

src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs

        {
-            throw new NotImplementedException();
+            ResultWrapper<ParityTxTraceFromStore[]> traceTransaction = trace_transaction(txHash);


Consideration - not sure if implement - keep small cache of recently traced transactions?

@LukaszRozmej agree with you, but firstly I think we need to correct trace bugs like:
#3422
#3034
#3312
#3298

MarekM25 · 2021-09-28T12:30:39Z

src/Nethermind/Nethermind.JsonRpc.Test/Modules/TraceRpcModuleTests.cs

-            Assert.AreEqual(
-                "{\"jsonrpc\":\"2.0\",\"result\":[{\"action\":{\"callType\":\"call\",\"from\":\"0x942921b14f1b1c385cd7e0cc2ef7abe5598c8358\",\"gas\":\"0x0\",\"input\":\"0x\",\"to\":\"0x0000000000000000000000000000000000000000\",\"value\":\"0x1\"},\"blockHash\":\"0xcd3d2c10309822aec4cbbfa80ba905ba1de62834a3b40f8012520734db2763ca\",\"blockNumber\":15,\"result\":{\"gasUsed\":\"0x0\",\"output\":\"0x\"},\"subtraces\":0,\"traceAddress\":[],\"transactionHash\":\"0xa1e0e640b433d5a8931881b8eee7b1a125474b04e430c0bf8afff52584c53273\",\"transactionPosition\":0,\"type\":\"call\"},{\"action\":{\"callType\":\"call\",\"from\":\"0x942921b14f1b1c385cd7e0cc2ef7abe5598c8358\",\"gas\":\"0x0\",\"input\":\"0x\",\"to\":\"0x0000000000000000000000000000000000000000\",\"value\":\"0x1\"},\"blockHash\":\"0xcd3d2c10309822aec4cbbfa80ba905ba1de62834a3b40f8012520734db2763ca\",\"blockNumber\":15,\"result\":{\"gasUsed\":\"0x0\",\"output\":\"0x\"},\"subtraces\":0,\"traceAddress\":[],\"transactionHash\":\"0x5cf5d4a0a93000beb1cfb373508ce4c0153ab491be99b3c927f482346c86a0e1\",\"transactionPosition\":1,\"type\":\"call\"},{\"action\":{\"callType\":\"call\",\"from\":\"0x942921b14f1b1c385cd7e0cc2ef7abe5598c8358\",\"gas\":\"0x0\",\"input\":\"0x\",\"to\":\"0x0000000000000000000000000000000000000000\",\"value\":\"0x1\"},\"blockHash\":\"0xcd3d2c10309822aec4cbbfa80ba905ba1de62834a3b40f8012520734db2763ca\",\"blockNumber\":15,\"result\":{\"gasUsed\":\"0x0\",\"output\":\"0x\"},\"subtraces\":0,\"traceAddress\":[],\"transactionHash\":\"0x02d2cde9120e37722f607771ebaa0d4e98c5d99a8a9e7df6872e8c8c9f5c0bc5\",\"transactionPosition\":2,\"type\":\"call\"},{\"action\":{\"callType\":\"call\",\"from\":\"0x942921b14f1b1c385cd7e0cc2ef7abe5598c8358\",\"gas\":\"0x0\",\"input\":\"0x\",\"to\":\"0x0000000000000000000000000000000000000000\",\"value\":\"0x1\"},\"blockHash\":\"0xcd3d2c10309822aec4cbbfa80ba905ba1de62834a3b40f8012520734db2763ca\",\"blockNumber\":15,\"result\":{\"gasUsed\":\"0x0\",\"output\":\"0x\"},\"subtraces\":0,\"traceAddress\":[],\"transactionHash\":\"0xe50a2a2d170011b1f9ee080c3810bed0c63dbb1b2b2c541c78ada5b222cc3fd2\",\"transactionPosition\":3,\"type\":\"call\"},{\"action\":{\"callType\":\"call\",\"from\":\"0x942921b14f1b1c385cd7e0cc2ef7abe5598c8358\",\"gas\":\"0x0\",\"input\":\"0x\",\"to\":\"0x0000000000000000000000000000000000000000\",\"value\":\"0x1\"},\"blockHash\":\"0xcd3d2c10309822aec4cbbfa80ba905ba1de62834a3b40f8012520734db2763ca\",\"blockNumber\":15,\"result\":{\"gasUsed\":\"0x0\",\"output\":\"0x\"},\"subtraces\":0,\"traceAddress\":[],\"transactionHash\":\"0xff0d4524d379fc15c41a9b0444b943e1a530779b7d09c8863858267c5ef92b24\",\"transactionPosition\":4,\"type\":\"call\"},{\"action\":{\"callType\":\"call\",\"from\":\"0x942921b14f1b1c385cd7e0cc2ef7abe5598c8358\",\"gas\":\"0x0\",\"input\":\"0x\",\"to\":\"0x0000000000000000000000000000000000000000\",\"value\":\"0x1\"},\"blockHash\":\"0xcd3d2c10309822aec4cbbfa80ba905ba1de62834a3b40f8012520734db2763ca\",\"blockNumber\":15,\"result\":{\"gasUsed\":\"0x0\",\"output\":\"0x\"},\"subtraces\":0,\"traceAddress\":[],\"transactionHash\":\"0xf9b69366c82084e3799dc4a7ad87dc173ef4923d853bc250de86b81786f2972a\",\"transactionPosition\":5,\"type\":\"call\"},{\"action\":{\"callType\":\"call\",\"from\":\"0x942921b14f1b1c385cd7e0cc2ef7abe5598c8358\",\"gas\":\"0x0\",\"input\":\"0x\",\"to\":\"0x0000000000000000000000000000000000000000\",\"value\":\"0x1\"},\"blockHash\":\"0xcd3d2c10309822aec4cbbfa80ba905ba1de62834a3b40f8012520734db2763ca\",\"blockNumber\":15,\"result\":{\"gasUsed\":\"0x0\",\"output\":\"0x\"},\"subtraces\":0,\"traceAddress\":[],\"transactionHash\":\"0x28171c29b23cd96f032fe43f444402af4555ee5f074d5d0d0a1089d940f136e7\",\"transactionPosition\":6,\"type\":\"call\"},{\"action\":{\"callType\":\"call\",\"from\":\"0x942921b14f1b1c385cd7e0cc2ef7abe5598c8358\",\"gas\":\"0x0\",\"input\":\"0x\",\"to\":\"0x0000000000000000000000000000000000000000\",\"value\":\"0x1\"},\"blockHash\":\"0xcd3d2c10309822aec4cbbfa80ba905ba1de62834a3b40f8012520734db2763ca\",\"blockNumber\":15,\"result\":{\"gasUsed\":\"0x0\",\"output\":\"0x\"},\"subtraces\":0,\"traceAddress\":[],\"transactionHash\":\"0x09b01caf4b7ecfe9d02251b2e478f2da0fdf08412e3fa1ff963fa80635dab031\",\"transactionPosition\":7,\"type\":\"call\"},{\"action\":{\"callType\":\"call\",\"from\":\"0x942921b14f1b1c385cd7e0cc2ef7abe5598c8358\",\"gas\":\"0x0\",\"input\":\"0x\",\"to\":\"0x0000000000000000000000000000000000000000\",\"value\":\"0x1\"},\"blockHash\":\"0xcd3d2c10309822aec4cbbfa80ba905ba1de62834a3b40f8012520734db2763ca\",\"blockNumber\":15,\"result\":{\"gasUsed\":\"0x0\",\"output\":\"0x\"},\"subtraces\":0,\"traceAddress\":[],\"transactionHash\":\"0xd82382905afbe4ca4c2b8e54cea43818c91e0014c3827e3020fbd82b732b8239\",\"transactionPosition\":8,\"type\":\"call\"},{\"action\":{\"author\":\"0x475674cb523a0a2736b7f7534390288fce16982c\",\"rewardType\":\"block\",\"value\":\"0x1bc16d674ec80000\"},\"blockHash\":\"0xcd3d2c10309822aec4cbbfa80ba905ba1de62834a3b40f8012520734db2763ca\",\"blockNumber\":15,\"subtraces\":0,\"traceAddress\":[],\"type\":\"reward\"}],\"id\":67}",
-            serialized, serialized.Replace("\"", "\\\""));
+                // , serialized.Replace("\"", "\\\"")


cosmetic - remove

MarekM25 · 2021-09-28T12:34:06Z

src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs

        {
            using CancellationTokenSource cancellationTokenSource = new(_cancellationTokenTimeout);
            CancellationToken cancellationToken = cancellationTokenSource.Token;

            ParityLikeBlockTracer listener = new(txHash, traceTypes);
            _tracer.Trace(block, listener.WithCancellation(cancellationToken));

-            return listener.BuildResult().SingleOrDefault();


Could you add the tests to trace_replayTransactions with Trace and Rewards flags?

MarekM25 · 2021-09-28T12:36:52Z

src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs

        {
-            throw new NotImplementedException();
+            ResultWrapper<ParityTxTraceFromStore[]> traceTransaction = trace_transaction(txHash);


@LukaszRozmej agree with you, but firstly I think we need to correct trace bugs like:
#3422
#3034
#3312
#3298

This reverts commit 7f6c0ef

kjazgar and others added 30 commits September 2, 2021 15:19

added test for trace_transaction

902da85

Changed trace_transaction and added test for it.

f6c8702

add tests

3906714

add multi call tests

2595e37

Merge branch 'trace_transaction_fixes' into changes_in_trace_module

0ab560e

# Conflicts: # src/Nethermind/Nethermind.JsonRpc.Test/Modules/TraceRpcModuleTests.cs

add reward calculator to TraceRpcModuleTests

d4d48c6

Merge branch 'trace_transaction_fixes' into changes_in_trace_module

173bed4

And fix :)

5e15799

build fixes

a3c1163

Merge branch 'trace_transaction_fixes' into changes_in_trace_module

1d222e7

# Conflicts: # src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs

Changes in TraceTx.

522bfda

Merge remote-tracking branch 'origin/master' into changes_in_trace_mo…

9fe8971

…dule # Conflicts: # src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs

small refactoring

777804a

Changed TraceTx as not to return a SingleOrDefault value.

e3dcd69

Deleted unnecessary part.

6284525

Fixed test.

4742619

Implemented trace_callMany and added test.

50a0e8e

Implemented trace_get and added test.

786d7aa

Changed params in trace_callMany.

283d167

fix

7015aad

Changed parameters, added class.

d2eeb66

fix

40390fe

Changed parameters in trace_callMany - test.

5e301a2

Merge branch 'implementation_trace_callMany' into implementation_trac…

99225c6

…e_get

Changes in trace_get - test.

5a3994d

Changes in trace_get.

892e4c6

Changed parameter type in trace_get.

e2be58b

Added error field to txTrace - test.

accd501

Deleted unnecessary part.

55785ae

Implementation of trace_get.

15f5c73

Deleted unnecessary parts.

cfa9b8a

kjazgar requested review from MarekM25 and LukaszRozmej September 21, 2021 12:27

Deleted unnecessary part.

8463f1a

LukaszRozmej reviewed Sep 22, 2021

View reviewed changes

MarekM25 reviewed Sep 28, 2021

View reviewed changes

Added tests for trace_replayTransaction.

0667474

kjazgar requested review from MarekM25 and LukaszRozmej October 6, 2021 20:24

LukaszRozmej approved these changes Oct 8, 2021

View reviewed changes

LukaszRozmej merged commit 7f6c0ef into master Oct 8, 2021

LukaszRozmej deleted the implementation_trace_get branch October 8, 2021 13:39

marcindsobczak added a commit that referenced this pull request Oct 20, 2021

Revert "Implementation trace get (#3436)"

a54f45a

This reverts commit 7f6c0ef

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation trace get #3436

Implementation trace get #3436

kjazgar commented Sep 21, 2021 •

edited

LukaszRozmej Sep 22, 2021

MarekM25 Sep 28, 2021

MarekM25 Sep 28, 2021

MarekM25 Sep 28, 2021

MarekM25 Sep 28, 2021

Implementation trace get #3436

Implementation trace get #3436

Conversation

kjazgar commented Sep 21, 2021 • edited

Changes:

Types of changes

Testing

LukaszRozmej Sep 22, 2021

Choose a reason for hiding this comment

MarekM25 Sep 28, 2021

Choose a reason for hiding this comment

MarekM25 Sep 28, 2021

Choose a reason for hiding this comment

MarekM25 Sep 28, 2021

Choose a reason for hiding this comment

MarekM25 Sep 28, 2021

Choose a reason for hiding this comment

kjazgar commented Sep 21, 2021 •

edited