Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf/journal for evm state #3514

Merged
merged 16 commits into from
Oct 13, 2021
Merged

Perf/journal for evm state #3514

merged 16 commits into from
Oct 13, 2021

Conversation

LukaszRozmej
Copy link
Member

Changes:

Uses Journals with snapshots in EvmState instead of copying data

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Needs manual testing on mainnet nodes

@LukaszRozmej LukaszRozmej marked this pull request as draft October 11, 2021 23:20
@LukaszRozmej LukaszRozmej marked this pull request as ready for review October 12, 2021 13:53
Copy link
Member

@tkstanczak tkstanczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please try to add many comments documenting this thing -> it is a great new piece of code but sooner or later we need to improve comments quality and it may be good to ask for it now especially for big new clean pieces of code

@LukaszRozmej LukaszRozmej merged commit cec4142 into master Oct 13, 2021
@LukaszRozmej LukaszRozmej deleted the perf/journal_for_evm_state branch October 13, 2021 12:24
marcindsobczak added a commit that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants