Trace transaction fix #3515
Merged
Trace transaction fix #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Nethermind/Nethermind.JsonRpc.Test/Modules/TraceRpcModuleTests.cs
# Conflicts: # src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs
…dule # Conflicts: # src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs
# Conflicts: # src/Nethermind/Nethermind.Evm/Tracing/ParityStyle/ParityLikeBlockTracer.cs # src/Nethermind/Nethermind.JsonRpc.Test/Modules/TraceRpcModuleTests.cs # src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs
LukaszRozmej
approved these changes
Oct 12, 2021
| @@ -88,5 +90,7 @@ private ParityTxTraceFromStore() | |||
|
|
|||
| [JsonProperty(NullValueHandling = NullValueHandling.Include)] | |||
| public string Type { get; set; } | |||
|
|
|||
| public string? Error { get; set; } | |||
There was a problem hiding this comment.
should it have NullValueHandling?
There was a problem hiding this comment.
the right question, I changed it
There was a problem hiding this comment.
Both Type and Error should be ignored if null?
There was a problem hiding this comment.
Do we definitely want to remove NullValueHandling from Type?
MarekM25
approved these changes
Oct 13, 2021
marcindsobczak
added a commit
that referenced
this pull request
Oct 20, 2021
This reverts commit 7dbeba6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #
Changes:
Resolved issue #3422 regarding missing error property.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??