Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TxBroadcaster #3530

Merged
merged 8 commits into from Oct 18, 2021
Merged

Fix TxBroadcaster #3530

merged 8 commits into from Oct 18, 2021

Conversation

marcindsobczak
Copy link
Contributor

Changes:

  • remove txs with stale nonces from persistent txs pool
  • broadcast only PeerNotificationThreshold (dafault value: 1%) of txs in persistent txs pool to every peer after every timer elapse (every 1s) instead of broadcasting whole persistent pool
  • increase size of NotifiedTransactions cache from 1x MemPoolSize to 2x

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

@LukaszRozmej LukaszRozmej merged commit 0af6b2c into master Oct 18, 2021
@LukaszRozmej LukaszRozmej deleted the fix_broadcaster branch October 18, 2021 18:38
marcindsobczak added a commit that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants