Register converters for socket's JSON RPC #3539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dceleda
commented
Oct 20, 2021
| @@ -52,6 +52,8 @@ public async Task Execute(CancellationToken cancellationToken) | |||
|
|
|||
| JsonRpcService jsonRpcService = new(_api.RpcModuleProvider, _api.LogManager); | |||
|
|
|||
| _api.EthereumJsonSerializer.RegisterConverters(jsonRpcService.Converters); | |||
There was a problem hiding this comment.
This change will register JSON RPC converters for the API serializer that is used in multiple places. Is it OK ?
HTTP JSON RPC uses own instance of the serializer. Maybe we should do the same for the sockets or share the same instance with the HTTP module ?
There was a problem hiding this comment.
Moved to a single serializer. So for now we have 2 serializers, the one in API is more about internal structures and types. We have second for JSON rpc responses.
LukaszRozmej
approved these changes
Oct 21, 2021
LukaszRozmej
deleted the
bug/3537_DifferentAnswersFromJsonRpcAndWebsockets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3537
Changes:
Register JSON converters for WebSockets and IPC.
Types of changes
Testing
Requires testing
In case you checked yes, did you write tests??