Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync dispatcher in single feed mode by adding continuation #3637

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

LukaszRozmej
Copy link
Member

Fixes #3089

Changes:

Properly handles single feed dispatched requests

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Will test on POA nodes as they experience the issue daily.

@LukaszRozmej LukaszRozmej merged commit 29bfd3b into master Nov 25, 2021
@LukaszRozmej LukaszRozmej deleted the fix/fullsync_catchup_issue branch November 25, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When following the chain if some block notifications are missed we don't switch full sync on xdai
4 participants