Fix Healthchecks UI package, update language targets #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
changed the title
LukaszRozmej
commented
Nov 26, 2021
| cp $RELEASE_DIRECTORY/$RELEASE_PATH/Nethermind.{HealthChecks,Merge.Plugin,Mev,Consensus}.dll $WIN_RELEASE/plugins | ||
| cp $RELEASE_DIRECTORY/$RELEASE_PATH/Nethermind.{HealthChecks,Merge.Plugin,Mev,Consensus}.dll $LIN_ARM64_RELEASE/plugins | ||
| cp $RELEASE_DIRECTORY/$RELEASE_PATH/Nethermind.{HealthChecks,Merge.Plugin,Mev,Consensus}.dll $OSX_ARM64_RELEASE/plugins | ||
| cp $RELEASE_DIRECTORY/$RELEASE_PATH/Nethermind.{HealthChecks,Merge.Plugin,Mev,Api}.dll $LIN_RELEASE/plugins |
Comment on lines
+17
to
+19
| <PackageReference Include="AspNetCore.HealthChecks.UI" Version="6.0.1-rc2.4" /> | ||
| <PackageReference Include="AspNetCore.HealthChecks.UI.Client" Version="6.0.1-rc2.4" /> | ||
| <PackageReference Include="AspNetCore.HealthChecks.UI.InMemory.Storage" Version="6.0.1-rc2.4" /> |
There was a problem hiding this comment.
Those are causing issues, we need version 6, there is no stable yet.
MarekM25
approved these changes
Nov 29, 2021
matilote
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes issues with CLI by including Nethermind.Api.dll in the plugins.
Fixes issue with Healthckech UI by using .net 6 RC packages (.net 5 packages don't work due to changes in .net 6 and EF 6, that break reflection in EF 5)
Moves Language version to latest by default on all projects (doesn't need updating later).
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
In case you checked yes, did you write tests??
Tested the package on clean VM without dotnet installed.