Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SnapSync config an override to FastSync #4113

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

dceleda
Copy link
Contributor

@dceleda dceleda commented Jun 4, 2022

Resolves #4105

Changes:

  • Make SnapSync config an override in MultiSyncModeSelector

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

@dceleda dceleda changed the title Make SnapSync config an oveeride to FastSync Make SnapSync config an override to FastSync Jun 4, 2022
@dceleda dceleda force-pushed the feature/SnapSyncConfigOverride branch from 4ce9a82 to c1407f6 Compare June 4, 2022 13:16
@LukaszRozmej LukaszRozmej merged commit 8429a80 into master Jun 6, 2022
@LukaszRozmej LukaszRozmej deleted the feature/SnapSyncConfigOverride branch June 6, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make SnapSync config to be override of FastSync
2 participants