Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge/multi sync #4121

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Merge/multi sync #4121

merged 3 commits into from
Jun 7, 2022

Conversation

LukaszRozmej
Copy link
Member

Changes:

Allows beacon sync modes to mix in parallel with old ones

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

@LukaszRozmej
sync changes
cf86e46
@LukaszRozmej
Merge remote-tracking branch 'origin/master' into merge/multi-sync
65182f6 
# Conflicts:
#	src/Nethermind/Nethermind.Synchronization/ParallelSync/MultiSyncModeSelector.cs
#	src/Nethermind/Nethermind.Synchronization/ParallelSync/SyncMode.cs
@LukaszRozmej
Make MultiSyncModeSelector allow parallel sync with BeaconSync
7e12f35
@MarekM25 MarekM25 marked this pull request as ready for review June 7, 2022 13:53
@MarekM25 MarekM25 self-requested a review June 7, 2022 13:54
@LukaszRozmej LukaszRozmej merged commit 5570585 into master Jun 7, 2022
@LukaszRozmej LukaszRozmej deleted the merge/multi-sync branch June 7, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flcl42 flcl42 flcl42 left review comments

@asdacap asdacap asdacap approved these changes

@MarekM25 MarekM25 MarekM25 approved these changes

@marcindsobczak marcindsobczak marcindsobczak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LukaszRozmej @flcl42 @asdacap @MarekM25 @marcindsobczak