Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnapSync enables FastSync #4132

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Jun 8, 2022

Resolves #4131

Changes:

  • Enable FastSync on config level if SnapSync is enabled

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

@flcl42 flcl42 marked this pull request as ready for review June 8, 2022 14:19
@dceleda dceleda merged commit 21d474f into master Jun 8, 2022
@dceleda dceleda deleted the hotfix/snapsync-enables-fastsync branch June 8, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config: syncConfig.SnapSync not overriding syncConfig.FastSync as expected
4 participants