Allow replacement of zero fee transactions #4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Jun 14, 2022
| @@ -40,6 +40,9 @@ public int Compare(Transaction? x, Transaction? y) | |||
| if (ReferenceEquals(null, y)) return 1; | |||
| if (ReferenceEquals(null, x)) return -1; | |||
|
|
|||
| // always allow replacement of zero fee txs (in legacy txs MaxFeePerGas equals GasPrice) | |||
| if (y.MaxFeePerGas == UInt256.Zero) return -1; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
More context: replacement of 0-fee transactions is needed for AuRa whitelisted accounts. Allowing general replacement of 0-fee transactions has much less complexity than loading whitelisted accounts from contract and allowing such replacement only for these accounts.
Types of changes
Testing
Requires testing
In case you checked yes, did you write tests??